From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Eichenberger <eichest@gmail.com>
Subject: Re: [PATCH 1/2] net: phy: Add BaseT1 auto-negotiation constants
Date: Tue, 19 Dec 2023 10:28:37 +0100 [thread overview]
Message-ID: <20231219092837.GB3479@debian> (raw)
In-Reply-To: <89f68405-2506-420b-952f-a168ebcb4d73@lunn.ch>
Am Tue, Dec 19, 2023 at 12:45:01AM +0100 schrieb Andrew Lunn:
> On Mon, Dec 18, 2023 at 11:18:13PM +0100, Dimitri Fedrau wrote:
> > Added constants for advertising 100BT1 and 1000BT1 in register BASE-T1
> > auto-negotiation advertisement register [31:16] (Register 7.515)
>
> Hi Dimitri
>
> These two patches look good, but...
>
> Please take a read of:
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
>
I probably should have sent them with subject-prefix "PATCH net-next" !?
> Also, its normal to include a user for new APIs. Do you have a driver
> which will make use of this to advertisement modes?
>
Yes, I'm currently trying to push a driver for the Marvell88Q2220
100BASE-T1/1000BASE-T1 PHY. It supports autonegotiation and with an
additional patch to function genphy_c45_baset1_an_config_aneg which is
not part of the series it is possible to set the advertised speed.
I probably should send all patches as a series including the driver ?
> Thanks
> Andrew
Best regards,
Dimitri
next prev parent reply other threads:[~2023-12-19 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 22:18 [PATCH 1/2] net: phy: Add BaseT1 auto-negotiation constants Dimitri Fedrau
2023-12-18 22:18 ` [PATCH 2/2] net: phy: Support 100BT1 and 1000BT1 linkmode advertisements Dimitri Fedrau
2023-12-18 23:45 ` [PATCH 1/2] net: phy: Add BaseT1 auto-negotiation constants Andrew Lunn
2023-12-19 9:28 ` Dimitri Fedrau [this message]
2023-12-19 16:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219092837.GB3479@debian \
--to=dima.fedrau@gmail.com \
--cc=andrew@lunn.ch \
--cc=eichest@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).