From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D62B14F68 for ; Tue, 19 Dec 2023 11:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UMDxoloA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0027CC433C7; Tue, 19 Dec 2023 11:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702983937; bh=Xan9OqFnkjXD7ZpmSsIbY/MakraHLHQyHXooQOvJ+VI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UMDxoloAmp6IbL4Ssnizmw1K75UjMC4/XVE5DWuwRrllGiZ6BqcWpmXgpfTCnbyQ5 w6IjTv3o57bfS0d67TZD3zYjz2rGMFpxjZdRFk1Kqp4r7M5Rejtlm8+RlhdKDlqs27 qlimxIPBHnRjRtXJCbkQeY0AUy88YAqdyjMUNlT2aa7scc5IFa/g8qywEwUWOvTF4q E2zPQKmVDgDMiD6o8QspCWAn5pQ4m/1L1F4u1bycanABvUBbyM82mwKEVynZ97H8S/ kphfPhHpGIGeC98UDPYoLkzeRs0qLXXtSceMjmDZBlb0lzQ51t1kNhVk7CnIYfmp0G M95CfCsnguQVQ== Date: Tue, 19 Dec 2023 11:05:33 +0000 From: Simon Horman To: Jedrzej Jagielski Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, Przemek Kitszel Subject: Re: [PATCH iwl-next v5 1/2] ixgbe: Refactor overtemp event handling Message-ID: <20231219110533.GH811967@kernel.org> References: <20231218103926.346294-1-jedrzej.jagielski@intel.com> <20231218103926.346294-2-jedrzej.jagielski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218103926.346294-2-jedrzej.jagielski@intel.com> On Mon, Dec 18, 2023 at 11:39:25AM +0100, Jedrzej Jagielski wrote: > Currently ixgbe driver is notified of overheating events > via internal IXGBE_ERR_OVERTEMP error code. > > Change the approach for handle_lasi() to use freshly introduced > is_overtemp function parameter which set when such event occurs. > Change check_overtemp() to bool and return true if overtemp > event occurs. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Jedrzej Jagielski > --- > v2: change aproach to use additional function parameter to notify when overheat > v4: change check_overtemp to bool > v5: adress Simon's comments Hi Jedrzej, Thanks for the updates, this version looks good to me. Reviewed-by: Simon Horman