From: Florian Westphal <fw@strlen.de>
To: "D. Wythe" <alibuda@linux.alibaba.com>
Cc: Simon Horman <horms@kernel.org>,
pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
ast@kernel.org
Subject: Re: [RFC nf-next v2 1/2] netfilter: bpf: support prog update
Date: Tue, 19 Dec 2023 15:58:13 +0100 [thread overview]
Message-ID: <20231219145813.GA28704@breakpoint.cc> (raw)
In-Reply-To: <2fd4fb88-8aaa-b22d-d048-776a6c19d9a6@linux.alibaba.com>
D. Wythe <alibuda@linux.alibaba.com> wrote:
> net/netfilter/nf_bpf_link.c:31:22: note: in expansion of macro
> ‘rcu_dereference’
> 31 | return bpf_prog_run(rcu_dereference((const struct bpf_prog __rcu
> *)nf_link->link.prog), &ctx);
> | ^~~~~~~~~~~~~~~
>
> So, I think we might need to go back to version 1.
>
> @ Florian , what do you think ?
Use rcu_dereference_raw().
next prev parent reply other threads:[~2023-12-19 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 4:18 [RFC nf-next v2 0/2] netfilter: bpf: support prog update D. Wythe
2023-12-18 4:18 ` [RFC nf-next v2 1/2] " D. Wythe
2023-12-18 19:06 ` Simon Horman
2023-12-19 12:50 ` D. Wythe
2023-12-19 14:58 ` Florian Westphal [this message]
2023-12-20 12:40 ` D. Wythe
2023-12-18 4:18 ` [RFC nf-next v2 2/2] selftests/bpf: Add netfilter link prog update test D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219145813.GA28704@breakpoint.cc \
--to=fw@strlen.de \
--cc=alibuda@linux.alibaba.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).