From: Leon Romanovsky <leon@kernel.org>
To: longli@linuxonhyperv.com
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Ajay Sharma <sharmaajay@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Long Li <longli@microsoft.com>
Subject: Re: [Patch v4 0/3] Register with RDMA SOC interface and support for CQ
Date: Wed, 20 Dec 2023 10:27:58 +0200 [thread overview]
Message-ID: <20231220082758.GC136797@unreal> (raw)
In-Reply-To: <1702692255-23640-1-git-send-email-longli@linuxonhyperv.com>
On Fri, Dec 15, 2023 at 06:04:12PM -0800, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
>
> This patchset add support for registering a RDMA device with SoC for
> support of querying device capabilities, upcoming RC queue pairs and
> CQ interrupts.
>
> This patchset is partially based on Ajay Sharma's work:
> https://lore.kernel.org/netdev/1697494322-26814-1-git-send-email-sharmaajay@linuxonhyperv.com
>
> Changes in v2:
> Dropped the patches to create EQs for RC QP. They will be implemented with
> RC patches.
>
>
> Long Li (3):
> RDMA/mana_ib: register RDMA device with GDMA
> RDMA/mana_ib: query device capabilities
> RDMA/mana_ib: Add CQ interrupt support for RAW QP
>
> drivers/infiniband/hw/mana/cq.c | 34 ++++++-
> drivers/infiniband/hw/mana/device.c | 31 +++++--
> drivers/infiniband/hw/mana/main.c | 69 ++++++++++----
> drivers/infiniband/hw/mana/mana_ib.h | 53 +++++++++++
> drivers/infiniband/hw/mana/qp.c | 90 ++++++++++++++++---
> .../net/ethernet/microsoft/mana/gdma_main.c | 5 ++
> include/net/mana/gdma.h | 5 ++
> 7 files changed, 252 insertions(+), 35 deletions(-)
Applied with the following change in third patch.
diff --git a/drivers/infiniband/hw/mana/qp.c b/drivers/infiniband/hw/mana/qp.c
index 19998082a376..21ac9fcadf3f 100644
--- a/drivers/infiniband/hw/mana/qp.c
+++ b/drivers/infiniband/hw/mana/qp.c
@@ -443,17 +443,16 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd,
ibdev_dbg(&mdev->ib_dev,
"Failed copy udata for create qp-raw, %d\n",
err);
- goto err_destroy_wq_obj;
+ goto err_release_gdma_cq;
}
return 0;
-err_destroy_wq_obj:
- if (gdma_cq) {
- kfree(gdma_cq);
- gd->gdma_context->cq_table[send_cq->id] = NULL;
- }
+err_release_gdma_cq:
+ kfree(gdma_cq);
+ gd->gdma_context->cq_table[send_cq->id] = NULL;
+err_destroy_wq_obj:
mana_destroy_wq_obj(mpc, GDMA_SQ, qp->tx_object);
err_destroy_dma_region:
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-12-20 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 2:04 [Patch v4 0/3] Register with RDMA SOC interface and support for CQ longli
2023-12-16 2:04 ` [Patch v4 1/3] RDMA/mana_ib: register RDMA device with GDMA longli
2023-12-16 2:04 ` [Patch v4 2/3] RDMA/mana_ib: query device capabilities longli
2023-12-16 2:04 ` [Patch v4 3/3] RDMA/mana_ib: Add CQ interrupt support for RAW QP longli
2023-12-17 13:25 ` [Patch v4 0/3] Register with RDMA SOC interface and support for CQ Leon Romanovsky
2023-12-18 18:23 ` Long Li
2023-12-20 7:40 ` Leon Romanovsky
2023-12-20 8:27 ` Leon Romanovsky [this message]
2023-12-20 8:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220082758.GC136797@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).