From: Simon Horman <horms@kernel.org>
To: Alexander Sapozhnikov <alsp705@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] net: fddi: skfp: Uninitialized data
Date: Wed, 20 Dec 2023 15:34:01 +0100 [thread overview]
Message-ID: <20231220143401.GH882741@kernel.org> (raw)
In-Reply-To: <20231219100819.17426-1-alsp705@gmail.com>
On Tue, Dec 19, 2023 at 01:08:19PM +0300, Alexander Sapozhnikov wrote:
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Alexander Sapozhnikov <alsp705@gmail.com>
Hi,
I think that more explanation is required regarding the problem
this solves and how it might affect users.
> ---
> drivers/net/fddi/skfp/pmf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fddi/skfp/pmf.c b/drivers/net/fddi/skfp/pmf.c
> index 563fb7f0b327..3f24fbd82a73 100644
> --- a/drivers/net/fddi/skfp/pmf.c
> +++ b/drivers/net/fddi/skfp/pmf.c
> @@ -1084,7 +1084,7 @@ static int smt_set_para(struct s_smc *smc, struct smt_para *pa, int index,
> int path ;
> int port ;
> SK_LOC_DECL(u_char,byte_val) ;
> - SK_LOC_DECL(u_short,word_val) ;
> + SK_LOC_DECL(u_short, word_val) = 0 ;
> SK_LOC_DECL(u_long,long_val) ;
>
> mac = index - INDEX_MAC ;
> --
> 2.40.1
>
>
prev parent reply other threads:[~2023-12-20 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 10:08 [PATCH] net: fddi: skfp: Uninitialized data Alexander Sapozhnikov
2023-12-20 14:34 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220143401.GH882741@kernel.org \
--to=horms@kernel.org \
--cc=alsp705@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).