From: Christian Brauner <brauner@kernel.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Andrii Nakryiko <andrii@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Peter Zijlstra <peterz@infradead.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Kernel Team <kernel-team@fb.com>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: pull-request: bpf-next 2023-12-18
Date: Thu, 21 Dec 2023 14:05:57 +0100 [thread overview]
Message-ID: <20231221-wolldecke-burggraben-40f9b60cee83@brauner> (raw)
In-Reply-To: <CAEf4BzYMJ1DCnRCXv4q=M-QG29Bgm+jrnkEuXNivmGmHShjnPg@mail.gmail.com>
> Of course, and you'll be CC'ed on all the BPF token patches I will
> resend after the holidays.
>
> And just to be clear for the future, by "core fs semantics" you also
> mean any BPF UAPI FD field, right?
Yes, because ultimately you end up with calling:
fdget()/fdget_raw()/fget()
to turn a userspace handle in the form of an fd and turn it into a
struct file. And that is uniform across the kernel. And therein lies the
beauty of it all imo.
IMHO, a file descriptor is one of the most widely used generic
abstraction we have across all of the kernel. It is almost literally
used everywhere. And everyone has the same contract: a non-negative
integer is a valid fd, a negative one is invalid. It's simple, there
aren't corner cases, there aren't custom semantics.
And it's also arguably one of the most successful ones as we keep
implementing new apis on top of this abstraction (pidfd, seccomp,
process_*(), memfd_*(), endless kvm ioctls etc etc).
prev parent reply other threads:[~2023-12-21 13:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 0:05 pull-request: bpf-next 2023-12-18 Alexei Starovoitov
2023-12-19 0:19 ` Alexei Starovoitov
2023-12-19 0:55 ` Jakub Kicinski
2023-12-19 1:17 ` Linus Torvalds
2023-12-19 1:10 ` patchwork-bot+netdevbpf
2023-12-19 1:11 ` Linus Torvalds
2023-12-19 1:48 ` Alexei Starovoitov
2023-12-19 3:57 ` Linus Torvalds
2023-12-19 4:34 ` Andrii Nakryiko
2023-12-19 5:38 ` Andrii Nakryiko
2023-12-19 10:23 ` Christian Brauner
2023-12-19 16:06 ` Matthew Wilcox
2023-12-19 16:51 ` Alexei Starovoitov
2023-12-19 16:36 ` Daniel Borkmann
2023-12-19 16:42 ` Alexei Starovoitov
2023-12-19 18:31 ` Andrii Nakryiko
2023-12-20 11:18 ` Christian Brauner
2023-12-20 19:17 ` Andrii Nakryiko
2023-12-21 13:05 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221-wolldecke-burggraben-40f9b60cee83@brauner \
--to=brauner@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox