From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v2] i40e: add trace events related to SFP module IOCTLs
Date: Thu, 21 Dec 2023 16:35:19 +0100 [thread overview]
Message-ID: <20231221153519.GB1056991@kernel.org> (raw)
In-Reply-To: <20231220173837.3326983-1-aleksandr.loktionov@intel.com>
On Wed, Dec 20, 2023 at 06:38:37PM +0100, Aleksandr Loktionov wrote:
> Add trace events related to SFP module IOCTLs for troubleshooting.
>
> Example:
> echo "i40e_*" >/sys/kernel/tracing/set_ftrace_filter
> echo "i40e_ioctl*" >/sys/kernel/tracing/events/i40e/filter
> echo 1 >/sys/kernel/tracing/tracing_on
> echo 1 >/sys/kernel/tracing/events/i40e/enable
> ...
> cat /sys/kernel/tracing/trace
>
> Riewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> ---
> v1->v2 applied to proper git branch
> ---
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 5 +++++
> drivers/net/ethernet/intel/i40e/i40e_trace.h | 18 ++++++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index c841779..bdf2b6b 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -1074,6 +1074,7 @@ static int i40e_get_link_ksettings(struct net_device *netdev,
> ethtool_link_ksettings_zero_link_mode(ks, supported);
> ethtool_link_ksettings_zero_link_mode(ks, advertising);
>
> + i40e_trace(ioctl_get_link_ksettings, pf, hw_link_info->link_info);
> if (link_up)
> i40e_get_settings_link_up(hw, ks, netdev, pf);
> else
Hi Aleksandr,
I think that i40e_trace.h needs to be included in i40e_ethtool.c
as part of this patch.
.../i40e_ethtool.c: In function ‘i40e_get_link_ksettings’:
.../i40e_ethtool.c:1077:9: error: implicit declaration of function ‘i40e_trace’ [-Werror=implicit-function-declaration]
1077 | i40e_trace(ioctl_get_link_ksettings, pf, hw_link_info->link_info);
| ^~~~~~~~~~
...
Flagged by gcc-13 W=1 build
...
--
pw-bot: changes-requested
next prev parent reply other threads:[~2023-12-21 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 17:38 [PATCH iwl-next v2] i40e: add trace events related to SFP module IOCTLs Aleksandr Loktionov
2023-12-21 15:35 ` Simon Horman [this message]
2023-12-21 16:27 ` Loktionov, Aleksandr
2023-12-22 23:39 ` kernel test robot
2023-12-23 9:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221153519.GB1056991@kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).