From: Vladimir Oltean <olteanv@gmail.com>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: netdev@vger.kernel.org, linus.walleij@linaro.org,
alsi@bang-olufsen.dk, andrew@lunn.ch, f.fainelli@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, arinc.unal@arinc9.com
Subject: Re: [PATCH net-next v2 2/7] net: dsa: realtek: convert variants into real drivers
Date: Thu, 21 Dec 2023 19:08:37 +0200 [thread overview]
Message-ID: <20231221170837.mn4utavzesq3ahz7@skbuf> (raw)
In-Reply-To: <20231220042632.26825-3-luizluca@gmail.com>
On Wed, Dec 20, 2023 at 01:24:25AM -0300, Luiz Angelo Daros de Luca wrote:
> +static int rtl8365mb_init(void)
> +{
> + int ret;
> +
> + ret = realtek_mdio_driver_register(&rtl8365mb_mdio_driver);
> + if (ret)
> + return ret;
> +
> + ret = platform_driver_register(&rtl8365mb_smi_driver);
I guess this was supposed to be a call to realtek_smi_driver_register().
> + if (ret) {
> + realtek_mdio_driver_unregister(&rtl8365mb_mdio_driver);
> + return ret;
> + }
> +
> + return 0;
> +}
> +module_init(rtl8365mb_init);
> +
> +static void __exit rtl8365mb_exit(void)
> +{
> + platform_driver_unregister(&rtl8365mb_smi_driver);
And this to realtek_smi_driver_unregister().
> + realtek_mdio_driver_unregister(&rtl8365mb_mdio_driver);
> +}
> +module_exit(rtl8365mb_exit);
next prev parent reply other threads:[~2023-12-21 17:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 4:24 [PATCH net-next v2 0/7] net: dsa: realtek: variants to drivers, interfaces to a common module Luiz Angelo Daros de Luca
2023-12-20 4:24 ` [PATCH net-next v2 1/7] net: dsa: realtek: drop cleanup from realtek_ops Luiz Angelo Daros de Luca
2023-12-20 13:57 ` Alvin Šipraga
2023-12-21 17:04 ` Vladimir Oltean
2023-12-21 20:05 ` Alvin Šipraga
2023-12-22 22:32 ` Luiz Angelo Daros de Luca
2023-12-20 4:24 ` [PATCH net-next v2 2/7] net: dsa: realtek: convert variants into real drivers Luiz Angelo Daros de Luca
2023-12-21 17:08 ` Vladimir Oltean [this message]
2023-12-20 4:24 ` [PATCH net-next v2 3/7] net: dsa: realtek: common realtek-dsa module Luiz Angelo Daros de Luca
2023-12-20 10:40 ` Alvin Šipraga
2023-12-20 15:50 ` Alvin Šipraga
2023-12-21 3:25 ` Luiz Angelo Daros de Luca
2023-12-21 3:11 ` Luiz Angelo Daros de Luca
2023-12-20 4:24 ` [PATCH net-next v2 4/7] net: dsa: realtek: merge common and interface modules into realtek-dsa Luiz Angelo Daros de Luca
2023-12-20 4:24 ` [PATCH net-next v2 5/7] net: dsa: realtek: Migrate user_mii_bus setup to realtek-dsa Luiz Angelo Daros de Luca
2023-12-20 4:51 ` Luiz Angelo Daros de Luca
2023-12-21 17:47 ` Vladimir Oltean
2023-12-21 18:34 ` Arınç ÜNAL
2023-12-22 10:48 ` Vladimir Oltean
2023-12-22 11:13 ` Alvin Šipraga
2023-12-22 17:04 ` Arınç ÜNAL
2023-12-22 20:28 ` Luiz Angelo Daros de Luca
2023-12-22 20:59 ` Arınç ÜNAL
2023-12-22 16:56 ` Arınç ÜNAL
2024-01-03 18:44 ` Vladimir Oltean
2024-01-05 18:43 ` Arınç ÜNAL
2023-12-22 20:03 ` Luiz Angelo Daros de Luca
2023-12-22 22:09 ` Vladimir Oltean
2023-12-22 22:12 ` Luiz Angelo Daros de Luca
2023-12-20 13:17 ` Alvin Šipraga
2023-12-21 3:03 ` Luiz Angelo Daros de Luca
2023-12-20 4:24 ` [PATCH net-next v2 6/7] net: dsa: realtek: embed dsa_switch into realtek_priv Luiz Angelo Daros de Luca
2023-12-20 4:24 ` [PATCH net-next v2 7/7] Revert "net: dsa: OF-ware slave_mii_bus" Luiz Angelo Daros de Luca
2023-12-20 13:19 ` Alvin Šipraga
2023-12-21 3:45 ` Luiz Angelo Daros de Luca
2023-12-21 0:41 ` kernel test robot
2023-12-21 15:21 ` [PATCH net-next v2 0/7] net: dsa: realtek: variants to drivers, interfaces to a common module Vladimir Oltean
2023-12-22 21:32 ` Luiz Angelo Daros de Luca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221170837.mn4utavzesq3ahz7@skbuf \
--to=olteanv@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox