netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Aptel <aaptel@nvidia.com>
To: linux-nvme@lists.infradead.org, netdev@vger.kernel.org,
	sagi@grimberg.me, hch@lst.de, kbusch@kernel.org, axboe@fb.com,
	chaitanyak@nvidia.com, davem@davemloft.net, kuba@kernel.org
Cc: aaptel@nvidia.com, aurelien.aptel@gmail.com, smalin@nvidia.com,
	malin1024@gmail.com, ogerlitz@nvidia.com, yorayz@nvidia.com,
	borisp@nvidia.com, galshalom@nvidia.com, mgurtovoy@nvidia.com,
	viro@zeniv.linux.org.uk
Subject: [PATCH v22 03/20] iov_iter: skip copy if src == dst for direct data placement
Date: Thu, 21 Dec 2023 21:33:41 +0000	[thread overview]
Message-ID: <20231221213358.105704-4-aaptel@nvidia.com> (raw)
In-Reply-To: <20231221213358.105704-1-aaptel@nvidia.com>

From: Ben Ben-Ishay <benishay@nvidia.com>

When using direct data placement (DDP) the NIC could write the payload
directly into the destination buffer and constructs SKBs such that
they point to this data. To skip copies when SKB data already resides
in the destination buffer we check if (src == dst), and skip the copy
when it's true.

Signed-off-by: Ben Ben-Ishay <benishay@nvidia.com>
Signed-off-by: Boris Pismenny <borisp@nvidia.com>
Signed-off-by: Or Gerlitz <ogerlitz@nvidia.com>
Signed-off-by: Yoray Zack <yorayz@nvidia.com>
Signed-off-by: Shai Malin <smalin@nvidia.com>
Signed-off-by: Aurelien Aptel <aaptel@nvidia.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
---
 lib/iov_iter.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/lib/iov_iter.c b/lib/iov_iter.c
index 8ff6824a1005..b96d8b6f5818 100644
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -62,7 +62,14 @@ static __always_inline
 size_t memcpy_to_iter(void *iter_to, size_t progress,
 		      size_t len, void *from, void *priv2)
 {
-	memcpy(iter_to, from + progress, len);
+	/*
+	 * When using direct data placement (DDP) the hardware writes
+	 * data directly to the destination buffer, and constructs
+	 * IOVs such that they point to this data.
+	 * Thus, when the src == dst we skip the memcpy.
+	 */
+	if (iter_to != from + progress)
+		memcpy(iter_to, from + progress, len);
 	return 0;
 }
 
-- 
2.34.1


  parent reply	other threads:[~2023-12-21 21:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21 21:33 [PATCH v22 00/20] nvme-tcp receive offloads Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 01/20] net: Introduce direct data placement tcp offload Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 02/20] netlink: add new family to manage ULP_DDP enablement and stats Aurelien Aptel
2024-01-02 10:08   ` Jiri Pirko
2023-12-21 21:33 ` Aurelien Aptel [this message]
2023-12-21 21:33 ` [PATCH v22 04/20] net/tls,core: export get_netdev_for_sock Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 05/20] nvme-tcp: Add DDP offload control path Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 06/20] nvme-tcp: Add DDP data-path Aurelien Aptel
2024-01-09  9:34   ` Aurelien Aptel
2024-01-10 16:05     ` Sagi Grimberg
2024-01-17 10:03       ` Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 07/20] nvme-tcp: RX DDGST offload Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 08/20] nvme-tcp: Deal with netdevice DOWN events Aurelien Aptel
2024-01-10 16:01   ` Sagi Grimberg
2024-01-17 10:05     ` Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 09/20] Documentation: add ULP DDP offload documentation Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 10/20] net/mlx5e: Rename from tls to transport static params Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 11/20] net/mlx5e: Refactor ico sq polling to get budget Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 12/20] net/mlx5: Add NVMEoTCP caps, HW bits, 128B CQE and enumerations Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 13/20] net/mlx5e: NVMEoTCP, offload initialization Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 14/20] net/mlx5e: TCP flow steering for nvme-tcp acceleration Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 15/20] net/mlx5e: NVMEoTCP, use KLM UMRs for buffer registration Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 16/20] net/mlx5e: NVMEoTCP, queue init/teardown Aurelien Aptel
2023-12-23 17:48   ` Simon Horman
2023-12-26 12:58     ` Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 17/20] net/mlx5e: NVMEoTCP, ddp setup and resync Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 18/20] net/mlx5e: NVMEoTCP, async ddp invalidation Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 19/20] net/mlx5e: NVMEoTCP, data-path for DDP+DDGST offload Aurelien Aptel
2023-12-21 21:33 ` [PATCH v22 20/20] net/mlx5e: NVMEoTCP, statistics Aurelien Aptel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231221213358.105704-4-aaptel@nvidia.com \
    --to=aaptel@nvidia.com \
    --cc=aurelien.aptel@gmail.com \
    --cc=axboe@fb.com \
    --cc=borisp@nvidia.com \
    --cc=chaitanyak@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=galshalom@nvidia.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=malin1024@gmail.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@nvidia.com \
    --cc=sagi@grimberg.me \
    --cc=smalin@nvidia.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yorayz@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).