From: Conor Dooley <conor@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
Rob Herring <robh@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [net-next PATCH v4 1/4] dt-bindings: net: phy: Document new LEDs polarity property
Date: Fri, 22 Dec 2023 15:20:56 +0000 [thread overview]
Message-ID: <20231222-pennant-staging-00e984b69fd3@spud> (raw)
In-Reply-To: <ce55a08f-ebe0-4e1b-a235-695e71611203@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
On Thu, Dec 21, 2023 at 10:43:17AM +0100, Andrew Lunn wrote:
> > On the marvell10g series we are discussing of using tristate or not. We
> > notice tristate might be confusing, would it be better to use
> > inactive-high-impedance ?
>
> The pincfg-node.yaml binding has:
>
> drive-open-drain:
> oneOf:
> - type: boolean
> - $ref: /schemas/types.yaml#/definitions/uint32
> const: 1 # No known cases of 0
> deprecated: true
> description: drive with open drain
>
> drive-open-source:
> type: boolean
> description: drive with open source
>
> I'm not sure what the deprecated means. Is it that a value is
> deprecated, not the property as a whole?
Yeah, it means that only the boolean form of this property should be
used going forward.
The comment suggests that the value had no meaning in the first place,
and that testing for presence alone has been sufficient all along.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-22 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 21:22 [net-next PATCH v4 0/4] net: phy: generic polarity + LED support for qca808x Christian Marangi
2023-12-15 21:22 ` [net-next PATCH v4 1/4] dt-bindings: net: phy: Document new LEDs polarity property Christian Marangi
2023-12-20 15:22 ` Rob Herring
2023-12-20 22:53 ` Christian Marangi
2023-12-21 9:43 ` Andrew Lunn
2023-12-22 15:20 ` Conor Dooley [this message]
2023-12-21 9:34 ` Andrew Lunn
2023-12-22 22:09 ` Christian Marangi
2023-12-15 21:22 ` [net-next PATCH v4 2/4] net: phy: add support for PHY LEDs polarity modes Christian Marangi
2023-12-15 21:22 ` [net-next PATCH v4 3/4] dt-bindings: net: Document QCA808x PHYs Christian Marangi
2023-12-15 21:22 ` [net-next PATCH v4 4/4] net: phy: at803x: add LED support for qca808x Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222-pennant-staging-00e984b69fd3@spud \
--to=conor@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox