From: Simon Horman <horms@kernel.org>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: ahmed.zaki@intel.com, netdev@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, Jeff Guo <jia.guo@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: [PATCH net-next] Revert "net: ethtool: add support for symmetric-xor RSS hash"
Date: Sun, 24 Dec 2023 20:54:12 +0000 [thread overview]
Message-ID: <20231224205412.GA5962@kernel.org> (raw)
In-Reply-To: <20231222210000.51989-1-gerhard@engleder-embedded.com>
+ Jeff Guo <jia.guo@intel.com>
Jesse Brandeburg <jesse.brandeburg@intel.com>
Tony Nguyen <anthony.l.nguyen@intel.com>
On Fri, Dec 22, 2023 at 10:00:00PM +0100, Gerhard Engleder wrote:
> This reverts commit 13e59344fb9d3c9d3acd138ae320b5b67b658694.
>
> The tsnep driver and at least also the macb driver implement the ethtool
> operation set_rxnfc but not the get_rxfh operation. With this commit
> set_rxnfc returns -EOPNOTSUPP if get_rxfh is not implemented. This renders
> set_rxnfc unuseable for drivers without get_rxfh.
>
> Make set_rxfnc working again for drivers without get_rxfh by reverting
> that commit.
>
> Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Hi Gerhard,
I think it would be nice to find a way forwards that resolved
the regression without reverting the feature. But, if that doesn't work
out, I think the following two patches need to be reverted first in
order to avoid breaking (x86_64 allmodconfig) builds.
352e9bf23813 ("ice: enable symmetric-xor RSS for Toeplitz hash function")
4a3de3fb0eb6 ("iavf: enable symmetric-xor RSS for Toeplitz hash function")
--
pw-bot: changes-requested
next prev parent reply other threads:[~2023-12-24 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 21:00 [PATCH net-next] Revert "net: ethtool: add support for symmetric-xor RSS hash" Gerhard Engleder
2023-12-24 20:54 ` Simon Horman [this message]
2023-12-24 22:03 ` Gerhard Engleder
2024-01-03 17:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224205412.GA5962@kernel.org \
--to=horms@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=jesse.brandeburg@intel.com \
--cc=jia.guo@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).