From: Simon Horman <horms@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
aleksander.lobakin@intel.com, marcin.szycik@linux.intel.com
Subject: Re: [PATCH iwl-next v2 14/15] ice: cleanup inconsistent code
Date: Mon, 25 Dec 2023 09:37:53 +0000 [thread overview]
Message-ID: <20231225093753.GG5962@kernel.org> (raw)
In-Reply-To: <5a163d97-2989-e5f7-e6ba-6dd346ab4236@intel.com>
On Thu, Dec 14, 2023 at 08:16:38AM +0100, Przemek Kitszel wrote:
> On 12/13/23 19:27, Jesse Brandeburg wrote:
> > Please don't use HTML email, your reply was likely dropped by most lists
> > that filter HTML.
> >
> > On 12/12/2023 8:06 PM, Kalesh Anakkur Purayil wrote:
> > > - change_type = FIELD_GET(ICE_AQ_LLDP_MIB_TYPE_M, mib->type);
> > > + change_type = FIELD_GET(ICE_AQ_LLDP_MIB_TYPE_M, mib->type);
> > >
> > > [Kalesh]: I did not get what exactly changed here? Is that you just
> > > removed one extra space before mib->type?
> >
> > Yes, there was a whitespace change missed in the GET series. I had
> > caught it only here. If you feel I need to I can resend to add a comment
> > to the commit message that this was added here.
> >
> >
>
> I guess that NOT sending next revision is our only chance to fix this
> particular white space error ;)
It would be nice if there was a mechanism to fix such problems.
Regardless of this side topic, this patch looks good to me,
with or without the extra space removed.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-12-25 9:37 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 1:00 [PATCH iwl-next v2 00/15] intel: use bitfield operations Jesse Brandeburg
2023-12-06 1:01 ` [PATCH iwl-next v2 01/15] e1000e: make lost bits explicit Jesse Brandeburg
2023-12-19 7:57 ` [Intel-wired-lan] " naamax.meir
2023-12-25 9:36 ` Simon Horman
2023-12-06 1:01 ` [PATCH iwl-next v2 02/15] intel: add bit macro includes where needed Jesse Brandeburg
2023-12-25 9:35 ` Simon Horman
2023-12-06 1:01 ` [PATCH iwl-next v2 03/15] intel: legacy: field prep conversion Jesse Brandeburg
2023-12-13 2:58 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-06 1:01 ` [PATCH iwl-next v2 04/15] i40e: " Jesse Brandeburg
2023-12-13 2:58 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-06 1:01 ` [PATCH iwl-next v2 05/15] iavf: " Jesse Brandeburg
2023-12-14 13:08 ` [Intel-wired-lan] " Romanowski, Rafal
2023-12-06 1:01 ` [PATCH iwl-next v2 06/15] ice: " Jesse Brandeburg
2023-12-13 2:58 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-06 1:01 ` [PATCH iwl-next v2 07/15] ice: fix pre-shifted bit usage Jesse Brandeburg
2023-12-13 2:57 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-06 1:01 ` [PATCH iwl-next v2 08/15] igc: field prep conversion Jesse Brandeburg
2023-12-06 1:01 ` [PATCH iwl-next v2 09/15] intel: legacy: field get conversion Jesse Brandeburg
2023-12-13 2:57 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-06 1:01 ` [PATCH iwl-next v2 10/15] igc: " Jesse Brandeburg
2023-12-06 1:01 ` [PATCH iwl-next v2 11/15] i40e: " Jesse Brandeburg
2023-12-13 2:57 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-06 1:01 ` [PATCH iwl-next v2 12/15] iavf: " Jesse Brandeburg
2023-12-14 13:10 ` [Intel-wired-lan] " Romanowski, Rafal
2023-12-06 1:01 ` [PATCH iwl-next v2 13/15] ice: " Jesse Brandeburg
2023-12-13 2:57 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-06 1:01 ` [PATCH iwl-next v2 14/15] ice: cleanup inconsistent code Jesse Brandeburg
2023-12-13 2:57 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-13 4:06 ` Kalesh Anakkur Purayil
2023-12-13 18:27 ` Jesse Brandeburg
2023-12-14 3:26 ` Kalesh Anakkur Purayil
2023-12-14 7:16 ` Przemek Kitszel
2023-12-25 9:37 ` Simon Horman [this message]
2023-12-06 1:01 ` [PATCH iwl-next v2 15/15] idpf: refactor some missing field get/prep conversions Jesse Brandeburg
2023-12-22 18:48 ` [Intel-wired-lan] " Register, Scott
2023-12-25 9:36 ` Simon Horman
2023-12-14 13:09 ` [Intel-wired-lan] [PATCH iwl-next v2 00/15] intel: use bitfield operations Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231225093753.GG5962@kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).