netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Eli Schwartz <eschwartz93@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/2] configure: avoid un-recommended command substitution form
Date: Wed, 27 Dec 2023 16:46:10 -0800	[thread overview]
Message-ID: <20231227164610.7cbc38fe@hermes.local> (raw)
In-Reply-To: <20231218033056.629260-1-eschwartz93@gmail.com>

On Sun, 17 Dec 2023 22:30:52 -0500
Eli Schwartz <eschwartz93@gmail.com> wrote:

> The use of backticks to surround commands instead of "$(cmd)" is a
> legacy of the oldest pre-POSIX shells. It is confusing, unreliable, and
> hard to read. Its use is not recommended in new programs.
> 
> See: http://mywiki.wooledge.org/BashFAQ/082
> ---

This is needless churn, it works now, and bash is never going
to drop the syntax.

Plus, the patch is missing signed-off-by.

  parent reply	other threads:[~2023-12-28  0:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18  3:30 [PATCH iproute2 1/2] configure: avoid un-recommended command substitution form Eli Schwartz
2023-12-18  3:30 ` [PATCH iproute2 2/2] configure: use the portable printf to suppress newlines in messages Eli Schwartz
2023-12-28  0:46   ` Stephen Hemminger
2023-12-28  3:53     ` Eli Schwartz
2023-12-29  6:00     ` [PATCH 1/2] configure: avoid un-recommended command substitution form Eli Schwartz
2023-12-29  6:00       ` [PATCH 2/2] configure: use the portable printf to suppress newlines in messages Eli Schwartz
2024-01-01 19:03         ` Stephen Hemminger
2023-12-28  0:46 ` Stephen Hemminger [this message]
2023-12-28  3:57   ` [PATCH iproute2 1/2] configure: avoid un-recommended command substitution form Eli Schwartz
2023-12-29 19:36     ` Stephen Hemminger
2023-12-30  0:42       ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231227164610.7cbc38fe@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=eschwartz93@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).