From: Stephen Hemminger <stephen@networkplumber.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
Anjali Kulkarni <anjali.k.kulkarni@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] netlink: Improve exception handling in __netlink_kernel_create()
Date: Mon, 1 Jan 2024 10:13:48 -0800 [thread overview]
Message-ID: <20240101101348.66978156@hermes.local> (raw)
In-Reply-To: <477e5649-87e3-44d9-8226-010b9822e649@web.de>
On Sun, 31 Dec 2023 18:42:30 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 31 Dec 2023 17:26:41 +0100
>
> The kfree() function was called in one case by
> the __netlink_kernel_create() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
>
> Thus use another label.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
NAK
Please look at something else, calling kfree(NULL) is correct
and the preferred solution.
next prev parent reply other threads:[~2024-01-01 18:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-31 17:40 [PATCH 0/4] netlink: Adjustments for __netlink_kernel_create() Markus Elfring
2023-12-31 17:42 ` [PATCH 1/4] netlink: Improve exception handling in __netlink_kernel_create() Markus Elfring
2024-01-01 18:13 ` Stephen Hemminger [this message]
2023-12-31 17:44 ` [PATCH 2/4] netlink: Move an assignment for the variable “sk” " Markus Elfring
2024-01-01 0:54 ` kernel test robot
2024-01-01 10:22 ` Markus Elfring
2024-01-01 18:14 ` Stephen Hemminger
2023-12-31 17:46 ` [PATCH 3/4] netlink: Delete an unnecessary variable initialisation " Markus Elfring
2024-01-01 18:42 ` Stephen Hemminger
2023-12-31 17:48 ` [PATCH 4/4] netlink: Move an assignment for the variable “cb_mutex” " Markus Elfring
2024-01-01 18:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240101101348.66978156@hermes.local \
--to=stephen@networkplumber.org \
--cc=Markus.Elfring@web.de \
--cc=anjali.k.kulkarni@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).