From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Shachar Kagan <skagan@nvidia.com>,
netdev@vger.kernel.org, Bagas Sanjaya <bagasdotme@gmail.com>,
"Linux regression tracking (Thorsten Leemhuis)"
<regressions@leemhuis.info>
Subject: Re: [PATCH net-next] tcp: Revert no longer abort SYN_SENT when receiving some ICMP
Date: Tue, 2 Jan 2024 14:02:32 -0800 [thread overview]
Message-ID: <20240102140232.77915fc3@kernel.org> (raw)
In-Reply-To: <CANn89iLVg3H-GuZ6=_-Rc5Jk14T59pZcx1DF-3HApvsPuSpNXg@mail.gmail.com>
On Tue, 2 Jan 2024 10:46:13 +0100 Eric Dumazet wrote:
> > The issue appears while using Vagrant to manage nested VMs.
> > The steps are:
> > * create vagrant file
> > * vagrant up
> > * vagrant halt (VM is created but shut down)
> > * vagrant up - fail
>
> I would rather have an explanation, instead of reverting a valid patch.
+1 obviously. Your refusal to debug this any further does not put
nVidia's TCP / NVMe offload in a good light. On one hand you
claim to have TCP experts in house and are pushing TCP offloads and
on the other you can't debug a TCP issue for which you reportedly
have an easy repro? Does not add up.
next prev parent reply other threads:[~2024-01-02 22:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 9:00 [PATCH net-next] tcp: Revert no longer abort SYN_SENT when receiving some ICMP Leon Romanovsky
2024-01-02 9:46 ` Eric Dumazet
2024-01-02 9:58 ` Leon Romanovsky
2024-01-02 10:03 ` Eric Dumazet
2024-01-02 10:11 ` Eric Dumazet
2024-01-02 11:41 ` Leon Romanovsky
2024-01-02 15:31 ` Eric Dumazet
2024-01-02 18:01 ` Leon Romanovsky
2024-01-02 18:33 ` Eric Dumazet
2024-01-02 19:13 ` Leon Romanovsky
2024-01-02 22:02 ` Jakub Kicinski [this message]
2024-01-03 6:00 ` Leon Romanovsky
2024-01-08 15:52 ` Eric Dumazet
2024-01-09 13:26 ` Leon Romanovsky
2024-01-09 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102140232.77915fc3@kernel.org \
--to=kuba@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@leemhuis.info \
--cc=skagan@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).