From: Jakub Kicinski <kuba@kernel.org>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: netdev@vger.kernel.org, linyunsheng@huawei.com,
Jesper Dangaard Brouer <hawk@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] page_pool: Rename frag_users to pagecnt_bias
Date: Tue, 2 Jan 2024 15:35:47 -0800 [thread overview]
Message-ID: <20240102153547.58b23d35@kernel.org> (raw)
In-Reply-To: <20231220080147.740134-1-ilias.apalodimas@linaro.org>
On Wed, 20 Dec 2023 10:01:46 +0200 Ilias Apalodimas wrote:
> - long frag_users;
> + long pagecnt_bias;
IDK :(
pagecnt to mean suggests this is related to page refcount,
not page pool specific refcount.
More importantly bias is the large number by which we increment.
This counter counts how many of the bias references we actually
consumed. So how about bias_consumed? bias_used? bias_issued?
frags_alloced?
next prev parent reply other threads:[~2024-01-02 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 8:01 [PATCH net-next v2] page_pool: Rename frag_users to pagecnt_bias Ilias Apalodimas
2024-01-02 23:35 ` Jakub Kicinski [this message]
2024-01-09 7:02 ` Ilias Apalodimas
2024-01-10 9:46 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102153547.58b23d35@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).