From: Leon Romanovsky <leon@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC iproute2 0/8] rdma: print related patches
Date: Wed, 3 Jan 2024 14:19:42 +0200 [thread overview]
Message-ID: <20240103121942.GD10748@unreal> (raw)
In-Reply-To: <20240103003558.20615-1-stephen@networkplumber.org>
On Tue, Jan 02, 2024 at 04:34:25PM -0800, Stephen Hemminger wrote:
> This set of patches makes rdma comman behave more like the
> other commands in iproute2 around printing flags.
> There are some other things found while looking at that code.
>
> Stephen Hemminger (8):
> rdma: shorten print_ lines
> rdma: use standard flag for json
> rdma: make pretty behave like other commands
> rdma: make supress_errors a bit
> rdma: add oneline flag
> rdma: do not mix newline and json object
> rdma: remove duplicate forward declaration
> rdma: remove unused rd argument
>
In addition to Chengchang comments.
LGTM,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
prev parent reply other threads:[~2024-01-03 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 0:34 [RFC iproute2 0/8] rdma: print related patches Stephen Hemminger
2024-01-03 0:34 ` [RFC iproute2 1/8] rdma: shorten print_ lines Stephen Hemminger
2024-01-03 0:34 ` [RFC iproute2 2/8] rdma: use standard flag for json Stephen Hemminger
2024-01-03 0:34 ` [RFC iproute2 3/8] rdma: make pretty behave like other commands Stephen Hemminger
2024-01-03 0:34 ` [RFC iproute2 4/8] rdma: make supress_errors a bit Stephen Hemminger
2024-01-03 0:34 ` [RFC iproute2 5/8] rdma: add oneline flag Stephen Hemminger
2024-01-03 0:34 ` [RFC iproute2 6/8] rdma: do not mix newline and json object Stephen Hemminger
2024-01-03 3:40 ` Chengchang Tang
2024-01-03 0:34 ` [RFC iproute2 7/8] rdma: remove duplicate forward declaration Stephen Hemminger
2024-01-03 0:34 ` [RFC iproute2 8/8] rdma: remove unused rd argument Stephen Hemminger
2024-01-03 4:02 ` [RFC iproute2 0/8] rdma: print related patches Chengchang Tang
2024-01-03 12:19 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103121942.GD10748@unreal \
--to=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).