From: Jakub Kicinski <kuba@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH net] MAINTAINERS: I don't want to review Renesas Ethernet Switch driver
Date: Wed, 3 Jan 2024 13:37:35 -0800 [thread overview]
Message-ID: <20240103133735.7bd660b9@kernel.org> (raw)
In-Reply-To: <6498e2dd-7960-daeb-acce-a8d2207f3404@omp.ru>
On Wed, 3 Jan 2024 23:56:15 +0300 Sergey Shtylyov wrote:
> I don't know this hardware, I don't have the manuals for it, so I can't
> provide a good review. Let's exclude the Ethernet Switch related files.
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Index: net/MAINTAINERS
> ===================================================================
> --- net.orig/MAINTAINERS
> +++ net/MAINTAINERS
> @@ -18358,6 +18358,9 @@ L: linux-renesas-soc@vger.kernel.org
> F: Documentation/devicetree/bindings/net/renesas,*.yaml
> F: drivers/net/ethernet/renesas/
> F: include/linux/sh_eth.h
> +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml
> +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.*
> +X: drivers/net/ethernet/renesas/rswitch.*
First off, very nice to see a refinement of MAINTAINERS to narrow
down the scope and make it more precise. Thanks for doing that.
The solution itself is not very idiomatic, however :(
IIUC you want to support SuperH and the AVB implementation.
It'd be more usual to make the entry cover only the relevant files.
And for bonus points perhaps add an entry covering the switch files,
mark that entry as Orphan?
next prev parent reply other threads:[~2024-01-03 21:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 20:56 [PATCH net] MAINTAINERS: I don't want to review Renesas Ethernet Switch driver Sergey Shtylyov
2024-01-03 21:28 ` Simon Horman
2024-01-04 20:47 ` Sergey Shtylyov
2024-01-05 2:42 ` Yoshihiro Shimoda
2024-01-05 9:54 ` Simon Horman
2024-01-05 10:46 ` Sergey Shtylyov
2024-01-05 11:07 ` Simon Horman
2024-01-05 14:14 ` Jakub Kicinski
2024-01-09 1:42 ` Yoshihiro Shimoda
2024-01-09 1:50 ` Yoshihiro Shimoda
2024-01-03 21:37 ` Jakub Kicinski [this message]
2024-01-04 9:32 ` Wolfram Sang
2024-01-04 20:23 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103133735.7bd660b9@kernel.org \
--to=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).