From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Ahmed Zaki <ahmed.zaki@intel.com>
Subject: Re: [PATCH net-next] net: ethtool: Fix set RXNFC call on drivers with no RXFH support
Date: Wed, 3 Jan 2024 13:39:40 -0800 [thread overview]
Message-ID: <20240103133940.73888714@kernel.org> (raw)
In-Reply-To: <20240103191620.747837-1-gal@nvidia.com>
On Wed, 3 Jan 2024 21:16:20 +0200 Gal Pressman wrote:
> Some interfaces support get/set_rxnfc but not get/set_rxfh (mlx5 IPoIB
> for example).
> Instead of failing the RXNFC command, do the symmetric xor sanity check
> for interfaces that support get_rxfh only.
>
> Fixes: dcd8dbf9e734 ("net: ethtool: get rid of get/set_rxfh_context functions")
> Cc: Ahmed Zaki <ahmed.zaki@intel.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
Thanks, we got a similar patch from Gerhard, applied yesterday:
501869fecfbc ("net: ethtool: Fix symmetric-xor RSS RX flow hash check")
--
pw-bot: nap
next prev parent reply other threads:[~2024-01-03 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 19:16 [PATCH net-next] net: ethtool: Fix set RXNFC call on drivers with no RXFH support Gal Pressman
2024-01-03 21:39 ` Jakub Kicinski [this message]
2024-01-04 6:51 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103133940.73888714@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).