From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B891D6BE for ; Wed, 3 Jan 2024 21:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LfRFEyAl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2F18C433B9; Wed, 3 Jan 2024 21:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704317982; bh=0HrVSl54jYmE5eYqRcFCiH2DRtCFbci+W2VMEK50M4s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LfRFEyAlxQcs4smvuod9XfOQE0cBmex+P8iayJO+//3NHFYmzWCudnoNrMQx3lRGR ntNt5u81eeocHX4KPbEVl1F0ME19piaAOOoRxDKKKWLxYA6+11rWw65xGZFyt4YXjn cJHATLsgFFEFQIPpTqamOUGD4IK4v6RIie3KTDWTy+6oBTDylU1RN+o6E5svr3Qvsn q2rXmMeiPRWlBsrvwQynPU8OOq+a0XmweM37H41TZ90HI1S7ZIXorU0fSyZQI80at+ CNI2hxLSQqCdrFcemd5WiNOUpgQstXRMjBLlDx4u9yLypLzeWcZGf6wOyoe8W6ZdPx 0n+w2AeT6TAVQ== Date: Wed, 3 Jan 2024 13:39:40 -0800 From: Jakub Kicinski To: Gal Pressman Cc: "David S. Miller" , , Eric Dumazet , Paolo Abeni , Ahmed Zaki Subject: Re: [PATCH net-next] net: ethtool: Fix set RXNFC call on drivers with no RXFH support Message-ID: <20240103133940.73888714@kernel.org> In-Reply-To: <20240103191620.747837-1-gal@nvidia.com> References: <20240103191620.747837-1-gal@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Jan 2024 21:16:20 +0200 Gal Pressman wrote: > Some interfaces support get/set_rxnfc but not get/set_rxfh (mlx5 IPoIB > for example). > Instead of failing the RXNFC command, do the symmetric xor sanity check > for interfaces that support get_rxfh only. > > Fixes: dcd8dbf9e734 ("net: ethtool: get rid of get/set_rxfh_context functions") > Cc: Ahmed Zaki > Signed-off-by: Gal Pressman Thanks, we got a similar patch from Gerhard, applied yesterday: 501869fecfbc ("net: ethtool: Fix symmetric-xor RSS RX flow hash check") -- pw-bot: nap