* [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support
@ 2024-01-02 21:13 Thomas Lange
2024-01-02 21:21 ` Arnd Bergmann
2024-01-03 22:09 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Lange @ 2024-01-02 21:13 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: Willem de Bruijn, jthinz, arnd, deepa.kernel, davem, edumazet,
kuba, pabeni
Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
__sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
SO_TIMESTAMPING_NEW.
Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
Link: https://lore.kernel.org/netdev/6a7281bf-bc4a-4f75-bb88-7011908ae471@app.fastmail.com/
Signed-off-by: Thomas Lange <thomas@corelatus.se>
---
net/core/sock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/sock.c b/net/core/sock.c
index 51d52859e942..d02534c77413 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -2813,6 +2813,7 @@ int __sock_cmsg_send(struct sock *sk, struct cmsghdr *cmsg,
sockc->mark = *(u32 *)CMSG_DATA(cmsg);
break;
case SO_TIMESTAMPING_OLD:
+ case SO_TIMESTAMPING_NEW:
if (cmsg->cmsg_len != CMSG_LEN(sizeof(u32)))
return -EINVAL;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support
2024-01-02 21:13 [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support Thomas Lange
@ 2024-01-02 21:21 ` Arnd Bergmann
2024-01-02 22:01 ` Willem de Bruijn
2024-01-03 22:09 ` Jakub Kicinski
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2024-01-02 21:21 UTC (permalink / raw)
To: Thomas Lange, Netdev, linux-kernel
Cc: Willem de Bruijn, Jörn-Thorben Hinz, Deepa Dinamani,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
On Tue, Jan 2, 2024, at 22:13, Thomas Lange wrote:
> Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
> __sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
> SO_TIMESTAMPING_NEW.
>
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Link:
> https://lore.kernel.org/netdev/6a7281bf-bc4a-4f75-bb88-7011908ae471@app.fastmail.com/
> Signed-off-by: Thomas Lange <thomas@corelatus.se>
Cc: stable@vger.kernel.org
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support
2024-01-02 21:21 ` Arnd Bergmann
@ 2024-01-02 22:01 ` Willem de Bruijn
0 siblings, 0 replies; 4+ messages in thread
From: Willem de Bruijn @ 2024-01-02 22:01 UTC (permalink / raw)
To: Arnd Bergmann, Thomas Lange, Netdev, linux-kernel
Cc: Willem de Bruijn, Jörn-Thorben Hinz, Deepa Dinamani,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Arnd Bergmann wrote:
> On Tue, Jan 2, 2024, at 22:13, Thomas Lange wrote:
> > Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> > socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
> > __sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
> > SO_TIMESTAMPING_NEW.
> >
> > Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> > Link:
> > https://lore.kernel.org/netdev/6a7281bf-bc4a-4f75-bb88-7011908ae471@app.fastmail.com/
> > Signed-off-by: Thomas Lange <thomas@corelatus.se>
>
> Cc: stable@vger.kernel.org
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support
2024-01-02 21:13 [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support Thomas Lange
2024-01-02 21:21 ` Arnd Bergmann
@ 2024-01-03 22:09 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2024-01-03 22:09 UTC (permalink / raw)
To: Thomas Lange
Cc: netdev, linux-kernel, Willem de Bruijn, jthinz, arnd,
deepa.kernel, davem, edumazet, pabeni
On Tue, 2 Jan 2024 22:13:50 +0100 Thomas Lange wrote:
> Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> socket option SO_TIMESTAMPING_NEW. However, it was never implemented in
> __sock_cmsg_send thus breaking SO_TIMESTAMPING cmsg for platforms using
> SO_TIMESTAMPING_NEW.
>
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Link: https://lore.kernel.org/netdev/6a7281bf-bc4a-4f75-bb88-7011908ae471@app.fastmail.com/
> Signed-off-by: Thomas Lange <thomas@corelatus.se>
patch looks mangled, could you resend with git send-email?
There are multiple spaces at the start of the diff lines.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-03 22:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-02 21:13 [PATCH net] net: Implement missing SO_TIMESTAMPING_NEW cmsg support Thomas Lange
2024-01-02 21:21 ` Arnd Bergmann
2024-01-02 22:01 ` Willem de Bruijn
2024-01-03 22:09 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).