From: Simon Horman <horms@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH net] MAINTAINERS: I don't want to review Renesas Ethernet Switch driver
Date: Wed, 3 Jan 2024 21:28:22 +0000 [thread overview]
Message-ID: <20240103212822.GA48301@kernel.org> (raw)
In-Reply-To: <6498e2dd-7960-daeb-acce-a8d2207f3404@omp.ru>
+ Shimoda-san
On Wed, Jan 03, 2024 at 11:56:15PM +0300, Sergey Shtylyov wrote:
> I don't know this hardware, I don't have the manuals for it, so I can't
> provide a good review. Let's exclude the Ethernet Switch related files.
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Hi Sergey,
I don't know the back story to this, if there is one.
But could I suggest that:
1. The patch also updates the title MAINTAINERS section to cover the
remaining two drivers.
e.g.: RENESAS ETHERNET DRIVERS ->
RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS
Or alternatively, create separate sections for each driver.
n.b.: This may involve moving sections to maintain alphabetical order
by section title
2. Reaching out to Shimoda-san (CCed) or other relevant parties
to see if an appropriate maintainer or maintainers for the
Renesas Ethernet Switch driver can be found.
n.b.: It may still be a holiday period in Japan for the rest of the week.
3. Rephrase the subject and patch description as splitting out maintenance of
the Renesas Ethernet Switch driver .
> ---
> The patch is against the 'main' branch of DaveM's 'net.git' repo...
>
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: net/MAINTAINERS
> ===================================================================
> --- net.orig/MAINTAINERS
> +++ net/MAINTAINERS
> @@ -18358,6 +18358,9 @@ L: linux-renesas-soc@vger.kernel.org
> F: Documentation/devicetree/bindings/net/renesas,*.yaml
> F: drivers/net/ethernet/renesas/
> F: include/linux/sh_eth.h
> +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml
> +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.*
> +X: drivers/net/ethernet/renesas/rswitch.*
>
> RENESAS IDT821034 ASoC CODEC
> M: Herve Codina <herve.codina@bootlin.com>
next prev parent reply other threads:[~2024-01-03 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 20:56 [PATCH net] MAINTAINERS: I don't want to review Renesas Ethernet Switch driver Sergey Shtylyov
2024-01-03 21:28 ` Simon Horman [this message]
2024-01-04 20:47 ` Sergey Shtylyov
2024-01-05 2:42 ` Yoshihiro Shimoda
2024-01-05 9:54 ` Simon Horman
2024-01-05 10:46 ` Sergey Shtylyov
2024-01-05 11:07 ` Simon Horman
2024-01-05 14:14 ` Jakub Kicinski
2024-01-09 1:42 ` Yoshihiro Shimoda
2024-01-09 1:50 ` Yoshihiro Shimoda
2024-01-03 21:37 ` Jakub Kicinski
2024-01-04 9:32 ` Wolfram Sang
2024-01-04 20:23 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103212822.GA48301@kernel.org \
--to=horms@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).