Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Household Cang <canghousehold@aol.com>,
	Romain Gantois <romain.gantois@bootlin.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net v5 1/2] net: ethernet: cortina: Drop software checksum and TSO
Date: Thu, 4 Jan 2024 02:24:49 +0200	[thread overview]
Message-ID: <20240104002449.yx43fvp2ylbxs3wz@skbuf> (raw)
In-Reply-To: <20240102-new-gemini-ethernet-regression-v5-1-cf61ab3aa8cd@linaro.org> <20240102-new-gemini-ethernet-regression-v5-1-cf61ab3aa8cd@linaro.org>

Hi Linus,

On Tue, Jan 02, 2024 at 09:34:25PM +0100, Linus Walleij wrote:
> That begs the question why large TCP or UDP packets also have to
> bypass the checksumming (like e.g. ICMP does). If the hardware is
> splitting it into smaller packets per-MTU setting, and checksumming
> them, why is this happening then? I don't know. I know it is needed,
> from tests: the OpenWrt webserver uhttpd starts sending big skb:s (up
> to 2047 bytes, the max MTU) and above 1514 bytes it starts to fail
> and hang unless the bypass bit is set: the frames are not getting
> through.

This uhttpd traffic is plain TCP, or TCP wrapped in DSA?

  reply	other threads:[~2024-01-04  0:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02 20:34 [PATCH net v5 0/2] Fix a regression in the Gemini ethernet controller Linus Walleij
2024-01-02 20:34 ` [PATCH net v5 1/2] net: ethernet: cortina: Drop software checksum and TSO Linus Walleij
2024-01-04  0:24   ` Vladimir Oltean [this message]
2024-01-05  0:00     ` Linus Walleij
2024-01-05 11:32   ` Vladimir Oltean
2024-01-05 14:36     ` Eric Dumazet
2024-01-05 23:35     ` Linus Walleij
2024-01-05 14:40   ` Eric Dumazet
2024-01-02 20:34 ` [PATCH net v5 2/2] net: ethernet: cortina: Bypass checksumming engine of alien ethertypes Linus Walleij
2024-01-04  0:53   ` Vladimir Oltean
2024-01-06  0:17     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240104002449.yx43fvp2ylbxs3wz@skbuf \
    --to=olteanv@gmail.com \
    --cc=canghousehold@aol.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=romain.gantois@bootlin.com \
    --cc=ulli.kroll@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox