From: Jakub Kicinski <kuba@kernel.org>
To: Dmitry Safonov <dima@arista.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Christian Kujau <lists@nerdbynature.de>,
Salam Noureddine <noureddine@arista.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/tcp: Only produce AO/MD5 logs if there are any keys
Date: Thu, 4 Jan 2024 07:57:42 -0800 [thread overview]
Message-ID: <20240104075742.71e4399f@kernel.org> (raw)
In-Reply-To: <20240104-tcp_hash_fail-logs-v1-1-ff3e1f6f9e72@arista.com>
On Thu, 4 Jan 2024 13:42:39 +0000 Dmitry Safonov wrote:
> User won't care about inproper hash options in the TCP header if they
> don't use neither TCP-AO nor TCP-MD5. Yet, those logs can add up in
> syslog, while not being a real concern to the host admin:
> > kernel: TCP: TCP segment has incorrect auth options set for XX.20.239.12.54681->XX.XX.90.103.80 [S]
>
> Keep silent and avoid logging when there aren't any keys in the system.
>
> Side-note: I also defined static_branch_tcp_*() helpers to avoid more
> ifdeffery, going to remove more ifdeffery further with their help.
Wouldn't we be better off converting the prints to trace points.
The chances for hitting them due to malicious packets feels much
higher than dealing with a buggy implementation in the wild.
next prev parent reply other threads:[~2024-01-04 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 13:42 [PATCH] net/tcp: Only produce AO/MD5 logs if there are any keys Dmitry Safonov
2024-01-04 13:57 ` Dmitry Safonov
2024-01-04 15:57 ` Jakub Kicinski [this message]
2024-01-04 16:42 ` Dmitry Safonov
2024-01-04 16:58 ` Jakub Kicinski
2024-01-04 16:59 ` Eric Dumazet
2024-01-04 17:30 ` Dmitry Safonov
2024-01-04 17:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104075742.71e4399f@kernel.org \
--to=kuba@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).