From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>
Subject: Re: [PATCH net-next 05/10] net: dsa: qca8k: skip MDIO bus creation if its OF node has status = "disabled"
Date: Thu, 4 Jan 2024 17:49:27 +0200 [thread overview]
Message-ID: <20240104154927.dq3bsbzu55qefsqo@skbuf> (raw)
In-Reply-To: <ajlbpd63vpgkyvzflimq7qbzrdvgqizbg6qwj32qudd4ibgywm@ckdcvnsrm23u>
On Thu, Jan 04, 2024 at 03:44:48PM +0000, Alvin Šipraga wrote:
> On Thu, Jan 04, 2024 at 04:00:32PM +0200, Vladimir Oltean wrote:
> > Currently the driver calls the non-OF devm_mdiobus_register() rather
> > than devm_of_mdiobus_register() for this case, but it seems to rather
> > be a confusing coincidence, and not a real use case that needs to be
> > supported.
>
> I am not really sure about the use case, but I always thought that
> status = "disabled" sort of functions the same as if the node were
> simply never specified. But with your change, there is a behavioural
> difference between these two cases:
>
> (a) mdio unspecified => register "qca8k-legacy user mii"
> (b) mdio specified, but status = "disabled" => don't register anything
>
> Was this your intention?
Yeah, it was my intention. I'm not sure if I agree with your equivalence.
For example, PCI devices probe through enumeration. Their OF node is
optional, aka when absent, they still probe. But when an associated OF
node exists and has status = "disabled", they don't probe.
next prev parent reply other threads:[~2024-01-04 15:49 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 14:00 [PATCH net-next 00/10] ds->user_mii_bus cleanup (part 1) Vladimir Oltean
2024-01-04 14:00 ` [PATCH net-next 01/10] net: dsa: lantiq_gswip: delete irrelevant use of ds->phys_mii_mask Vladimir Oltean
2024-01-04 15:52 ` Alvin Šipraga
2024-01-04 17:07 ` Florian Fainelli
2024-01-04 14:00 ` [PATCH net-next 02/10] net: dsa: lantiq_gswip: use devres for internal MDIO bus, not ds->user_mii_bus Vladimir Oltean
2024-01-04 15:53 ` Alvin Šipraga
2024-01-04 17:36 ` Florian Fainelli
2024-01-05 2:43 ` Luiz Angelo Daros de Luca
2024-01-04 14:00 ` [PATCH net-next 03/10] net: dsa: lantiq_gswip: ignore MDIO buses disabled in OF Vladimir Oltean
2024-01-04 15:53 ` Alvin Šipraga
2024-01-04 17:36 ` Florian Fainelli
2024-01-04 14:00 ` [PATCH net-next 04/10] net: dsa: qca8k: put MDIO bus OF node on qca8k_mdio_register() failure Vladimir Oltean
2024-01-04 15:46 ` Alvin Šipraga
2024-01-04 17:20 ` Vladimir Oltean
2024-01-04 17:37 ` Florian Fainelli
2024-01-05 0:25 ` Luiz Angelo Daros de Luca
2024-01-04 14:00 ` [PATCH net-next 05/10] net: dsa: qca8k: skip MDIO bus creation if its OF node has status = "disabled" Vladimir Oltean
2024-01-04 15:44 ` Alvin Šipraga
2024-01-04 15:49 ` Vladimir Oltean [this message]
2024-01-04 16:04 ` Alvin Šipraga
2024-01-04 16:05 ` Alvin Šipraga
2024-01-04 17:38 ` Florian Fainelli
2024-01-05 2:19 ` Luiz Angelo Daros de Luca
2024-01-10 16:35 ` Vladimir Oltean
2024-01-04 14:00 ` [PATCH net-next 06/10] net: dsa: qca8k: assign ds->user_mii_bus only for the non-OF case Vladimir Oltean
2024-01-04 15:48 ` Alvin Šipraga
2024-01-04 17:35 ` Florian Fainelli
2024-01-05 2:35 ` Luiz Angelo Daros de Luca
2024-01-04 14:00 ` [PATCH net-next 07/10] net: dsa: qca8k: consolidate calls to a single devm_of_mdiobus_register() Vladimir Oltean
2024-01-04 15:49 ` Alvin Šipraga
2024-01-04 17:34 ` Florian Fainelli
2024-01-04 23:07 ` Christian Marangi
2024-01-05 2:26 ` Luiz Angelo Daros de Luca
2024-01-04 14:00 ` [PATCH net-next 08/10] net: dsa: qca8k: use "dev" consistently within qca8k_mdio_register() Vladimir Oltean
2024-01-04 15:50 ` Alvin Šipraga
2024-01-04 17:34 ` Florian Fainelli
2024-01-04 22:55 ` Christian Marangi
2024-01-05 2:21 ` Luiz Angelo Daros de Luca
2024-01-04 14:00 ` [PATCH net-next 09/10] net: dsa: bcm_sf2: stop assigning an OF node to the ds->user_mii_bus Vladimir Oltean
2024-01-04 15:59 ` Alvin Šipraga
2024-01-04 17:32 ` Florian Fainelli
2024-01-04 14:00 ` [PATCH net-next 10/10] net: dsa: bcm_sf2: drop priv->master_mii_dn Vladimir Oltean
2024-01-04 15:59 ` Alvin Šipraga
2024-01-04 17:32 ` Florian Fainelli
2024-01-05 2:48 ` Luiz Angelo Daros de Luca
2024-01-05 12:00 ` [PATCH net-next 00/10] ds->user_mii_bus cleanup (part 1) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104154927.dq3bsbzu55qefsqo@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=ALSI@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox