netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brett Creeley <brett.creeley@amd.com>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <shannon.nelson@amd.com>, <brett.creeley@amd.com>
Subject: [PATCH net-next 8/8] pds_core: Fix up some RCT issues
Date: Thu, 4 Jan 2024 09:12:21 -0800	[thread overview]
Message-ID: <20240104171221.31399-9-brett.creeley@amd.com> (raw)
In-Reply-To: <20240104171221.31399-1-brett.creeley@amd.com>

Running xmastree.py against the driver found some
RCT issues, so fix them.

Signed-off-by: Brett Creeley <brett.creeley@amd.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
---
 drivers/net/ethernet/amd/pds_core/debugfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/amd/pds_core/debugfs.c b/drivers/net/ethernet/amd/pds_core/debugfs.c
index dd6aaeecfe0a..d56fdbb4cdb9 100644
--- a/drivers/net/ethernet/amd/pds_core/debugfs.c
+++ b/drivers/net/ethernet/amd/pds_core/debugfs.c
@@ -32,8 +32,8 @@ void pdsc_debugfs_del_dev(struct pdsc *pdsc)
 
 static int identity_show(struct seq_file *seq, void *v)
 {
-	struct pdsc *pdsc = seq->private;
 	struct pds_core_dev_identity *ident;
+	struct pdsc *pdsc = seq->private;
 	int vt;
 
 	ident = &pdsc->dev_ident;
@@ -102,8 +102,7 @@ static const struct debugfs_reg32 intr_ctrl_regs[] = {
 
 void pdsc_debugfs_add_qcq(struct pdsc *pdsc, struct pdsc_qcq *qcq)
 {
-	struct dentry *qcq_dentry, *q_dentry, *cq_dentry;
-	struct dentry *intr_dentry;
+	struct dentry *qcq_dentry, *q_dentry, *cq_dentry, *intr_dentry;
 	struct debugfs_regset32 *intr_ctrl_regset;
 	struct pdsc_queue *q = &qcq->q;
 	struct pdsc_cq *cq = &qcq->cq;
-- 
2.17.1


  parent reply	other threads:[~2024-01-04 17:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 17:12 [PATCH net-next 0/8] pds_core: Various improvements and AQ race condition cleanup Brett Creeley
2024-01-04 17:12 ` [PATCH net-next 1/8] pds_core: Prevent health thread from running during reset/remove Brett Creeley
2024-01-04 17:12 ` [PATCH net-next 2/8] pds_core: Cancel AQ work on teardown Brett Creeley
2024-01-04 17:12 ` [PATCH net-next 3/8] pds_core: Use struct pdsc for the pdsc_adminq_isr private data Brett Creeley
2024-01-04 17:12 ` [PATCH net-next 4/8] pds_core: Prevent race issues involving the adminq Brett Creeley
2024-01-04 19:16   ` Simon Horman
2024-01-04 19:24     ` Brett Creeley
2024-01-06  1:50   ` kernel test robot
2024-01-07  1:28   ` kernel test robot
2024-01-04 17:12 ` [PATCH net-next 5/8] pds_core: Clear BARs on reset Brett Creeley
2024-01-04 17:12 ` [PATCH net-next 6/8] pds_core: Don't assign interrupt index/bound_intr to notifyq Brett Creeley
2024-01-04 17:12 ` [PATCH net-next 7/8] pds_core: Unmask adminq interrupt in work thread Brett Creeley
2024-01-04 17:12 ` Brett Creeley [this message]
2024-01-05  7:59 ` [PATCH net-next 0/8] pds_core: Various improvements and AQ race condition cleanup Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240104171221.31399-9-brett.creeley@amd.com \
    --to=brett.creeley@amd.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shannon.nelson@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).