From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>, Eyal Birger <eyal.birger@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, Florian Westphal <fw@strlen.de>,
victor@mojatatu.com
Subject: Re: [PATCH iproute2-next v2] remove support for iptables action
Date: Fri, 5 Jan 2024 06:09:46 -0800 [thread overview]
Message-ID: <20240105060946.221ca96f@kernel.org> (raw)
In-Reply-To: <CAM0EoMnSVQHyQy37OoznsF15+M84o7L2c6UwtKL1Fcuwev4rHA@mail.gmail.com>
On Fri, 5 Jan 2024 06:20:10 -0500 Jamal Hadi Salim wrote:
> > I tested and it looks like the patch doesn't affect em_ipt, as expected.
Thank you!
> > I did however run into a related issue while testing - seems that
> > using the old "ingress" qdisc - that em_ipt iproute2 code still uses -
> > isn't working, i.e:
> >
> > $ tc qdisc add dev ipsec1 ingress
> > Error: Egress block dev insert failed.
> >
> > This seems to originate from recent commit 913b47d3424e
> > ("net/sched: Introduce tc block netdev tracking infra").
> >
> > When I disabled that code in my build I was able to use em_ipt
> > as expected.
>
> Resolved in: https://lore.kernel.org/netdev/20240104125844.1522062-1-jiri@resnulli.us/
> Eyal, if you have cycles please give it a try. Jakub, can we get that applied?
FTR it was applied by Dave soon after you asked.
next prev parent reply other threads:[~2024-01-05 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 18:25 [PATCH iproute2-next v2] remove support for iptables action Stephen Hemminger
2023-12-27 17:25 ` Jamal Hadi Salim
2024-01-04 15:25 ` Jakub Kicinski
2024-01-04 16:15 ` Jamal Hadi Salim
2024-01-05 2:33 ` Eyal Birger
2024-01-05 11:20 ` Jamal Hadi Salim
2024-01-05 14:09 ` Jakub Kicinski [this message]
2024-01-06 4:15 ` Eyal Birger
2024-01-08 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105060946.221ca96f@kernel.org \
--to=kuba@kernel.org \
--cc=eyal.birger@gmail.com \
--cc=fw@strlen.de \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).