netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: netdev@vger.kernel.org, linus.walleij@linaro.org,
	alsi@bang-olufsen.dk, andrew@lunn.ch, f.fainelli@gmail.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, arinc.unal@arinc9.com
Subject: Re: [PATCH net-next v3 6/8] net: dsa: realtek: migrate user_mii_bus setup to realtek-dsa
Date: Mon, 8 Jan 2024 16:31:39 +0200	[thread overview]
Message-ID: <20240108143139.6igg5emhtdj2nh3o@skbuf> (raw)
In-Reply-To: <20231223005253.17891-7-luizluca@gmail.com> <20231223005253.17891-7-luizluca@gmail.com>

On Fri, Dec 22, 2023 at 09:46:34PM -0300, Luiz Angelo Daros de Luca wrote:
> In the user MDIO driver, despite numerous references to SMI, including
> its compatible string, there's nothing inherently specific about the SMI
> interface in the user MDIO bus. Consequently, the code has been migrated
> to the common module. All references to SMI have been eliminated.
> 
> The realtek-mdio will now use this driver instead of the generic DSA
> driver ("dsa user smi"), which should not be used with OF[1].
> 
> The driver now looks for the MDIO node searchking for a child node named
> "mdio" instead of using the compatible string. This requirement is
> already present in binding docs for both interfaces.
> 
> The line assigning dev.of_node in mdio_bus has been removed since the
> subsequent of_mdiobus_register will always overwrite it.
> 
> ds->user_mii_bus is not assigned anymore[2]. It should work as before as
> long as the switch ports have a valid phy-handle property.
> 
> With a single ds_ops for both interfaces, the ds_ops in realtek_priv is
> no longer necessary. Now, the realtek_variant.ds_ops can be used
> directly.
> 
> The realtek_priv.setup_interface() has been removed as we can directly
> call the new common function.
> 
> The switch unregistration and the MDIO node decrement in refcount were
> moved into realtek_common_remove() as both interfaces now need to put
> the MDIO node.

Can you please make all these individual changes separate patches,
some before moving the code to realtek_common, and some after?
There's a lot of stuff happening at once here.

  reply	other threads:[~2024-01-08 14:31 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-23  0:46 [PATCH net-next v3 0/8] net: dsa: realtek: variants to drivers, interfaces to a common module Luiz Angelo Daros de Luca
2023-12-23  0:46 ` [PATCH net-next v3 1/8] net: dsa: realtek: drop cleanup from realtek_ops Luiz Angelo Daros de Luca
2023-12-23 16:54   ` Florian Fainelli
2023-12-24 22:26   ` Linus Walleij
2023-12-23  0:46 ` [PATCH net-next v3 2/8] net: dsa: realtek: convert variants into real drivers Luiz Angelo Daros de Luca
2023-12-23  0:46 ` [PATCH net-next v3 3/8] net: dsa: realtek: common realtek-dsa module Luiz Angelo Daros de Luca
2024-01-08 14:00   ` Vladimir Oltean
2024-01-09  5:05     ` Luiz Angelo Daros de Luca
2024-01-09 12:36       ` Vladimir Oltean
2024-01-11  6:20         ` Luiz Angelo Daros de Luca
2024-01-11  9:41           ` Vladimir Oltean
2024-01-11 10:10             ` Alvin Šipraga
2024-01-12  2:15             ` Luiz Angelo Daros de Luca
2024-01-11  9:51   ` Vladimir Oltean
2024-01-11 19:53     ` Luiz Angelo Daros de Luca
2024-01-11 20:05       ` Vladimir Oltean
2024-01-13 21:38         ` Luiz Angelo Daros de Luca
2024-01-15 21:50           ` Vladimir Oltean
2023-12-23  0:46 ` [PATCH net-next v3 4/8] net: dsa: realtek: merge common and interface modules into realtek-dsa Luiz Angelo Daros de Luca
2024-01-08 14:11   ` Vladimir Oltean
2024-01-09  5:11     ` Luiz Angelo Daros de Luca
2024-01-09 12:49     ` Linus Walleij
2023-12-23  0:46 ` [PATCH net-next v3 5/8] net: dsa: realtek: get internal MDIO node by name Luiz Angelo Daros de Luca
2024-01-08 14:12   ` Vladimir Oltean
2023-12-23  0:46 ` [PATCH net-next v3 6/8] net: dsa: realtek: migrate user_mii_bus setup to realtek-dsa Luiz Angelo Daros de Luca
2024-01-08 14:31   ` Vladimir Oltean [this message]
2024-01-09  6:02     ` Luiz Angelo Daros de Luca
2023-12-23  0:46 ` [PATCH net-next v3 7/8] net: dsa: realtek: embed dsa_switch into realtek_priv Luiz Angelo Daros de Luca
2023-12-23  0:46 ` [PATCH net-next v3 8/8] Revert "net: dsa: OF-ware slave_mii_bus" Luiz Angelo Daros de Luca
2023-12-30  7:18   ` Arınç ÜNAL
2023-12-30 15:56     ` Arınç ÜNAL
2024-01-06 11:36       ` Arınç ÜNAL
2024-01-08  4:44         ` Luiz Angelo Daros de Luca
2024-01-08  9:48           ` Arınç ÜNAL
2024-01-15 21:54 ` [PATCH net-next v3 0/8] net: dsa: realtek: variants to drivers, interfaces to a common module Vladimir Oltean
2024-01-17 10:25   ` Arınç ÜNAL
2024-01-17 12:48     ` Linus Walleij
2024-01-20 22:13       ` Arınç ÜNAL
2024-01-29 17:45         ` Konstantin Ryabitsev
2024-01-30 23:21           ` Luiz Angelo Daros de Luca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240108143139.6igg5emhtdj2nh3o@skbuf \
    --to=olteanv@gmail.com \
    --cc=alsi@bang-olufsen.dk \
    --cc=andrew@lunn.ch \
    --cc=arinc.unal@arinc9.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=luizluca@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).