From: Lee Jones <lee@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH RESUBMIT] leds: trigger: netdev: add core support for hw not supporting fallback to LED sw control
Date: Thu, 11 Jan 2024 08:44:25 +0000 [thread overview]
Message-ID: <20240111084425.GJ7948@google.com> (raw)
In-Reply-To: <7b6cf0fb-4c77-4088-b87b-5649cfaa697e@gmail.com>
On Sun, 17 Dec 2023, Heiner Kallweit wrote:
> On 17.12.2023 19:46, Heiner Kallweit wrote:
> > If hw doesn't support sw control of the LED and we switch to a mode
> > not supported by hw, currently we get lots of errors because neither
> > brigthness_set() nor brithness_set_blocking() is set.
> > Deal with this by not falling back to sw control, and return
> > -EOPNOTSUPP to the user. Note that we still store the new mode.
> > This is needed in case an intermediate unsupported mode is necessary
> > to switch from one supported mode to another.
> >
> > Add a comment explaining how a driver for such hw is supposed to behave.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > ---
>
> For whatever reason this patch (original version and resubmit) doesn't
> show up on linux-leds patchwork. In netdev patchwork it's visible.
Never used it. Do you have a link?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-01-11 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 18:46 [PATCH RESUBMIT] leds: trigger: netdev: add core support for hw not supporting fallback to LED sw control Heiner Kallweit
2023-12-17 19:16 ` Heiner Kallweit
2024-01-11 8:44 ` Lee Jones [this message]
2024-01-11 10:24 ` Heiner Kallweit
2024-01-11 10:32 ` Lee Jones
2024-01-11 11:19 ` Heiner Kallweit
2023-12-18 9:45 ` Andrew Lunn
2023-12-21 15:05 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111084425.GJ7948@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).