netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH RESUBMIT] leds: trigger: netdev: add core support for hw not supporting fallback to LED sw control
Date: Thu, 11 Jan 2024 10:32:35 +0000	[thread overview]
Message-ID: <20240111103235.GA1665043@google.com> (raw)
In-Reply-To: <f0838b86-f008-4f14-8910-61b393d0190d@gmail.com>

On Thu, 11 Jan 2024, Heiner Kallweit wrote:

> On 11.01.2024 09:44, Lee Jones wrote:
> > On Sun, 17 Dec 2023, Heiner Kallweit wrote:
> > 
> >> On 17.12.2023 19:46, Heiner Kallweit wrote:
> >>> If hw doesn't support sw control of the LED and we switch to a mode
> >>> not supported by hw, currently we get lots of errors because neither
> >>> brigthness_set() nor brithness_set_blocking() is set.
> >>> Deal with this by not falling back to sw control, and return
> >>> -EOPNOTSUPP to the user. Note that we still store the new mode.
> >>> This is needed in case an intermediate unsupported mode is necessary
> >>> to switch from one supported mode to another.
> >>>
> >>> Add a comment explaining how a driver for such hw is supposed to behave.
> >>>
> >>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >>> ---
> >>
> >> For whatever reason this patch (original version and resubmit) doesn't
> >> show up on linux-leds patchwork. In netdev patchwork it's visible.
> > 
> > Never used it.  Do you have a link?
> > 
> This is the original patch in netdev patchwork
> https://patchwork.kernel.org/project/netdevbpf/patch/91e9f4c6-d869-45be-be72-ac49a3c3b818@gmail.com/
> 
> This is my patches in linux-leds patchwork. The one from Dec 6th is missing here.
> https://patches.linaro.org/project/linux-leds/list/?series=&submitter=6702&state=*&q=&archive=&delegate=
> However the resubmitted one showed up later.

AFAIW, that's not the official Patchwork for LEDs.

And as I say, I don't use it, so I'm not really in a position to comment.

Do we still have something outstanding?

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2024-01-11 10:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-17 18:46 [PATCH RESUBMIT] leds: trigger: netdev: add core support for hw not supporting fallback to LED sw control Heiner Kallweit
2023-12-17 19:16 ` Heiner Kallweit
2024-01-11  8:44   ` Lee Jones
2024-01-11 10:24     ` Heiner Kallweit
2024-01-11 10:32       ` Lee Jones [this message]
2024-01-11 11:19         ` Heiner Kallweit
2023-12-18  9:45 ` Andrew Lunn
2023-12-21 15:05 ` (subset) " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240111103235.GA1665043@google.com \
    --to=lee@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=hkallweit1@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).