From: Jakub Kicinski <kuba@kernel.org>
To: wangkeqi <wangkeqi_chris@163.com>
Cc: "Yin, Fengwei" <fengwei.yin@intel.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
wangkeqi <wangkeqiwang@didiglobal.com>
Subject: Re: [PATCH] connector: Change the judgment conditions for clearing proc_event_num_listeners
Date: Mon, 15 Jan 2024 15:59:39 -0800 [thread overview]
Message-ID: <20240115155939.5d206775@kernel.org> (raw)
In-Reply-To: <9ac38d2.916d.18d0c71c748.Coremail.wangkeqi_chris@163.com>
On Mon, 15 Jan 2024 17:26:39 +0800 (CST) wangkeqi wrote:
> From: wangkeqi <wangkeqiwang@didiglobal.com>
>
> It is inaccurate to judge whether proc_event_num_listeners is
> cleared by cn_netlink_send_mult returning -ESRCH.
> In the case of stress-ng netlink-proc, -ESRCH will always be returned,
> because netlink_broadcast_filtered will return -ESRCH,
> which may cause stress-ng netlink-proc performance degradation.
> Therefore, the judgment condition is modified to whether
> there is a listener.
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202401112259.b23a1567-oliver.sang@intel.com
> Signed-off-by: wangkeqi <wangkeqiwang@didiglobal.com>
> Cc: fengwei.yin@intel.com
Please stop posting the patches as a reply to the previous submission
with a quote at the end.. Post the new version generated by git with
--subject-prefix="PATCH net v2" and send it with git send-email as
a new thread.
Please add an appropriate Fixes tag.
--
pw-bot: cr
prev parent reply other threads:[~2024-01-15 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 7:51 [PATCH] connector: Change the judgment conditions for clearing proc_event_num_listeners wangkeqi
2024-01-15 7:57 ` Yin, Fengwei
2024-01-15 9:26 ` wangkeqi
2024-01-15 23:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115155939.5d206775@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fengwei.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangkeqi_chris@163.com \
--cc=wangkeqiwang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).