From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F0901B7E2; Mon, 15 Jan 2024 23:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="osiQcpyQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B971C433F1; Mon, 15 Jan 2024 23:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705363180; bh=/NQXU+ICRnTUS8fBizZVZS75t+q9655X3GTJxIPttf4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=osiQcpyQ1lrMVGlW3TQSRmSuGxmp+D3slzGc3WRe98ckxqiRLBmakOAg7xjHtVj4d 9L4ZWwoD7Hw7Z0/BFR/7wSDVzygOb8txtAVDTkQoWQyFlbxyuwt0WlcNROuTK2xtES IZM12grch7k/wwfTh1fMg9Cnx128ZH9AqMhHDnZCEIiPRk0HOkY15XMNLFvqg+AzQE OeKP8wnccCrRBz7nMu9qL7jqE0GZ/4E2ToFURq+arPuiMxi1LC4tYBpytyhWSs3WyA rFRNJ2D9vf7qOdXfFdmqG1rsUL9gwkisjMreWZNRRA88DnFLWi8fPkbjQ/wfZSGOSa /H0teNu/tjmnA== Date: Mon, 15 Jan 2024 15:59:39 -0800 From: Jakub Kicinski To: wangkeqi Cc: "Yin, Fengwei" , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wangkeqi Subject: Re: [PATCH] connector: Change the judgment conditions for clearing proc_event_num_listeners Message-ID: <20240115155939.5d206775@kernel.org> In-Reply-To: <9ac38d2.916d.18d0c71c748.Coremail.wangkeqi_chris@163.com> References: <20240115075120.186143-1-wangkeqi_chris@163.com> <7170ecaf-32e3-4bfc-b20d-a08a341ae381@intel.com> <9ac38d2.916d.18d0c71c748.Coremail.wangkeqi_chris@163.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 15 Jan 2024 17:26:39 +0800 (CST) wangkeqi wrote: > From: wangkeqi > > It is inaccurate to judge whether proc_event_num_listeners is > cleared by cn_netlink_send_mult returning -ESRCH. > In the case of stress-ng netlink-proc, -ESRCH will always be returned, > because netlink_broadcast_filtered will return -ESRCH, > which may cause stress-ng netlink-proc performance degradation. > Therefore, the judgment condition is modified to whether > there is a listener. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202401112259.b23a1567-oliver.sang@intel.com > Signed-off-by: wangkeqi > Cc: fengwei.yin@intel.com Please stop posting the patches as a reply to the previous submission with a quote at the end.. Post the new version generated by git with --subject-prefix="PATCH net v2" and send it with git send-email as a new thread. Please add an appropriate Fixes tag. -- pw-bot: cr