Re: [PATCH net-next v3 3/8] net: dsa: realtek: common realtek-dsa module

Luiz Angelo Daros de Luca
2024-01-13T21:38:53Z

> On Thu, Jan 11, 2024 at 04:53:01PM -0300, Luiz Angelo Daros de Luca wrote:
> > What do you mean by dropping the "common"? Use "realtek_probe" or
> > "realtek_dsa_probe"?
>
> Yes, I meant "realtek_probe()" etc. It's just that the word "common" has
> no added value in function names, and I can't come up with something
> good to replace it with.

I didn't like realtek_probe() either. It is too generic, although now
in a specific name space.
How about replacing all realtek_common with rtl83xx? I guess all
rtl83xx chips are switch controllers, even though some of them have an
embedded mips core.
Or we could include a prefix/suffix as well like rtl83xx_dsa or realtek_dsa..

Regards,

Luiz