Re: [PATCH net-next v3 3/8] net: dsa: realtek: common realtek-dsa module

Vladimir Oltean
2024-01-11T09:51:29Z

On Fri, Dec 22, 2023 at 09:46:31PM -0300, Luiz Angelo Daros de Luca wrote:
> +EXPORT_SYMBOL_GPL(realtek_common_lock);
> +EXPORT_SYMBOL_GPL(realtek_common_unlock);
> +EXPORT_SYMBOL(realtek_common_probe);
> +EXPORT_SYMBOL(realtek_common_register_switch);
> +EXPORT_SYMBOL(realtek_common_remove);

Is there any reason for the lack of consistency between GPL and non-GPL
symbols?

Also, I don't like too much the naming of symbols like "realtek_common_probe",
exported to the entire kernel. I wonder if it would be better to drop
the word "common" altogether, and use EXPORT_SYMBOL_NS_GPL(*, REALTEK_DSA) +
MODULE_IMPORT_NS(REALTEK_DSA) instead of plain EXPORT_SYMBOL_GPL()?