From: Jakub Kicinski <kuba@kernel.org>
To: Benjamin Poirier <bpoirier@nvidia.com>,
Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Shuah Khan <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Toppins <jon.toppins+linux@gmail.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Michal Kubiak <michal.kubiak@intel.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: bonding: Add more missing config options
Date: Tue, 16 Jan 2024 10:44:02 -0800 [thread overview]
Message-ID: <20240116104402.1203850a@kernel.org> (raw)
In-Reply-To: <20240116154926.202164-1-bpoirier@nvidia.com>
On Tue, 16 Jan 2024 10:49:26 -0500 Benjamin Poirier wrote:
> As a followup to commit 03fb8565c880 ("selftests: bonding: add missing
> build configs"), add more networking-specific config options which are
> needed for bonding tests.
>
> For testing, I used the minimal config generated by virtme-ng and I added
> the options in the config file. All bonding tests passed.
>
> Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management") # for ipv6
> Fixes: 6cbe791c0f4e ("kselftest: bonding: add num_grat_arp test") # for tc options
> Fixes: 222c94ec0ad4 ("selftests: bonding: add tests for ether type changes") # for nlmon
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
With this applied the only remaining bonding test which fails in our CI
is bond-options [1], good progress! :) Looks like it doesn't finish in
time:
not ok 7 selftests: drivers/net/bonding: bond_options.sh # TIMEOUT 120 seconds
The tests run in a VM without HW virtualization support. Any opinions
about bumping the timeout for bonding? If we enable KASAN etc. things
will get even slower.
[1]
https://netdev-2.bots.linux.dev/vmksft-bonding/results/423800/7-bond-options-sh
next prev parent reply other threads:[~2024-01-16 18:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 15:49 [PATCH net] selftests: bonding: Add more missing config options Benjamin Poirier
2024-01-16 18:44 ` Jakub Kicinski [this message]
2024-01-16 19:03 ` Jay Vosburgh
2024-01-16 19:20 ` Jakub Kicinski
2024-01-16 19:21 ` Benjamin Poirier
2024-01-16 19:29 ` Jakub Kicinski
2024-01-16 19:43 ` Jay Vosburgh
2024-01-16 19:47 ` Benjamin Poirier
2024-01-17 3:15 ` Hangbin Liu
2024-01-18 0:16 ` Benjamin Poirier
2024-01-18 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116104402.1203850a@kernel.org \
--to=kuba@kernel.org \
--cc=andy@greyhouse.net \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=jon.toppins+linux@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).