From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E9923742; Tue, 16 Jan 2024 19:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705434210; cv=none; b=jcdmm0bZI9Jsb+xzHHyxAB1Le6iFYVOgE74qv2FudnXOSO4k1MbIp3OnIjkoWQjVkDPsPTKNL+wMWRNIrQaqAK7dTKAzaBvEOhLvgmIPNQ9Au1jSK9ctptGYdvnarQjdDtkhS6ke5mdJrD74ZOvJg9Orxoin6iKfPNF12xxYXLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705434210; c=relaxed/simple; bh=ACQuwnrHOOPZAyDz3qTaDrzWugOxk+sx/8S41lB1OVI=; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version:X-stable: X-Patchwork-Hint:X-stable-base:Content-Transfer-Encoding; b=HAzKxziwfIdPTbK2Ge25plxUPHZn5L1I1LlLgXuPO4ScbqGHgXqmwrL0ni7iI3w4LWz5PRKSPrbO+JnnxSNTHC+5HU6xqr5RjO3igrNxplhSk1FHcrxPq/Px+IUoZD1mynkE7fXnB6lczwR5TfiVh29NUV1lHab+9ELvs02XfIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OrcmEIFp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OrcmEIFp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4A70C43399; Tue, 16 Jan 2024 19:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705434210; bh=ACQuwnrHOOPZAyDz3qTaDrzWugOxk+sx/8S41lB1OVI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OrcmEIFpaWKjGjypDVvSWD5bNsQ+9dba1cq/Qby0b/28rNGA00T9jX02FYtgPR++M vnHzcVG1kZyDmUaNNgYYdTxGZNpQuyPJxqHdPuwUN48KzEsc0eIKxrV7zH04S0jrg6 j0yENBr/Iag6lLjbS9GTW6LAKL5phxLxdVbzzqy6pkU6YmdXkU8sotO7gSyFIzRNzo Jko0Ih83RHFx3ZoN8jbvOxFklAAFS60+xtNrNK8tYLYYnPg8+lnGwgYTiKTKKGCExy QTb/9UVFZmyno+Lg8WtCRJ8MijxJYXI+CBy5xXJFTMiKaJK2bDI08GUb2Si2gy5rY0 2+aFg89El7NtA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jose Ignacio Tornos Martinez , Herb Wei , Jakub Kicinski , Sasha Levin , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, gregkh@linuxfoundation.org, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.7 023/108] net: usb: ax88179_178a: avoid two consecutive device resets Date: Tue, 16 Jan 2024 14:38:49 -0500 Message-ID: <20240116194225.250921-23-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116194225.250921-1-sashal@kernel.org> References: <20240116194225.250921-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.7 Content-Transfer-Encoding: 8bit From: Jose Ignacio Tornos Martinez [ Upstream commit d2689b6a86b9d23574bd4b654bf770b6034e2c7e ] The device is always reset two consecutive times (ax88179_reset is called twice), one from usbnet_probe during the device binding and the other from usbnet_open. Remove the non-necessary reset during the device binding and let the reset operation from open to keep the normal behavior (tested with generic ASIX Electronics Corp. AX88179 Gigabit Ethernet device). Reported-by: Herb Wei Tested-by: Herb Wei Signed-off-by: Jose Ignacio Tornos Martinez Link: https://lore.kernel.org/r/20231120121239.54504-1-jtornosm@redhat.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/ax88179_178a.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 5a1bf42ce156..d837c1887416 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1315,8 +1315,6 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) netif_set_tso_max_size(dev->net, 16384); - ax88179_reset(dev); - return 0; } -- 2.43.0