From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87179664D1; Tue, 16 Jan 2024 20:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705435405; cv=none; b=A8OJwo05tYSuXLkk8WUr1shNIusf7gOCmZxQ6ic/HDEp9J4ALWHUQRPXFYhOnF16dRVbRVvJxkZASsQFtDT+aWa13Cpa69wH9Xw5uaO18ds6ZcLqXeyxRAtb4uv7VAX7wOCvYXdV7XzFarS2UnPNlJwT2g+Ymwd4N68izkNYPfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705435405; c=relaxed/simple; bh=//aelGAg/QeIYKJGkfnYoGgJ5tLzJm/CkJm3mCuyLYU=; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version:X-stable: X-Patchwork-Hint:X-stable-base:Content-Transfer-Encoding; b=e5XHNGV5LQ/kasCxCGjwjBob6Z+zEeZeDy9qU0KrXLYzTTUH8WBRUpjtArzbUSvnvGCG4NCHmy16jr2+/m6+UAahpIXQ7SyV1dZjKv1X2laB/pfrcTQ4TGsmc/qvJHosT/uX5lU1tg3WeBtYW9sLqrBDE8MxsLR+BQRPf0ubY4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UzgBC6R7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UzgBC6R7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 205A5C43394; Tue, 16 Jan 2024 20:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705435405; bh=//aelGAg/QeIYKJGkfnYoGgJ5tLzJm/CkJm3mCuyLYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UzgBC6R7syfdts3ySayhrdei04A8+PDmvgOd0ZHl/F5dKuqpiFPWcxwgfwHabrxWU 8QgEIw8/yE+LtYMCo80FgrRtsdZcjjSi7iAKOhCyrj9dSc72nQg+ps5+95SbF17PJc /LXHrlzRd+0BdUce4UBxiS3lRZ++iTMFoTB5J1FXj274fKf3/R2s9KDcwLQk8I9vtI Vwofy75nR2UtJCVFakJ1PrNwF3Vac2Ib2WRDa+qPnWZm72KnUXMX/xRUJ/QCHYyp0K Bv5Hiq2Ew05f5iHKeqIF4KPlQErGZPiZZYCcUnxTKCoW0LL30AiZrdKvZm0gQV8tlM e5GHJMt1WC/pQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhengchao Shao , Jay Vosburgh , Paolo Abeni , Sasha Levin , j.vosburgh@gmail.com, andy@greyhouse.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 06/31] bonding: return -ENOMEM instead of BUG in alb_upper_dev_walk Date: Tue, 16 Jan 2024 15:02:15 -0500 Message-ID: <20240116200310.259340-6-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116200310.259340-1-sashal@kernel.org> References: <20240116200310.259340-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.267 Content-Transfer-Encoding: 8bit From: Zhengchao Shao [ Upstream commit d6b83f1e3707c4d60acfa58afd3515e17e5d5384 ] If failed to allocate "tags" or could not find the final upper device from start_dev's upper list in bond_verify_device_path(), only the loopback detection of the current upper device should be affected, and the system is no need to be panic. So return -ENOMEM in alb_upper_dev_walk to stop walking, print some warn information when failed to allocate memory for vlan tags in bond_verify_device_path. I also think that the following function calls netdev_walk_all_upper_dev_rcu ---->>>alb_upper_dev_walk ---------->>>bond_verify_device_path >From this way, "end device" can eventually be obtained from "start device" in bond_verify_device_path, IS_ERR(tags) could be instead of IS_ERR_OR_NULL(tags) in alb_upper_dev_walk. Signed-off-by: Zhengchao Shao Acked-by: Jay Vosburgh Link: https://lore.kernel.org/r/20231118081653.1481260-1-shaozhengchao@huawei.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/bonding/bond_alb.c | 3 ++- drivers/net/bonding/bond_main.c | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index 6df78a36bafd..342e23e56192 100644 --- a/drivers/net/bonding/bond_alb.c +++ b/drivers/net/bonding/bond_alb.c @@ -970,7 +970,8 @@ static int alb_upper_dev_walk(struct net_device *upper, void *_data) if (netif_is_macvlan(upper) && !strict_match) { tags = bond_verify_device_path(bond->dev, upper, 0); if (IS_ERR_OR_NULL(tags)) - BUG(); + return -ENOMEM; + alb_send_lp_vid(slave, upper->dev_addr, tags[0].vlan_proto, tags[0].vlan_id); kfree(tags); diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index bb1c6743222e..352afabf8571 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -2482,8 +2482,11 @@ struct bond_vlan_tag *bond_verify_device_path(struct net_device *start_dev, if (start_dev == end_dev) { tags = kcalloc(level + 1, sizeof(*tags), GFP_ATOMIC); - if (!tags) + if (!tags) { + net_err_ratelimited("%s: %s: Failed to allocate tags\n", + __func__, start_dev->name); return ERR_PTR(-ENOMEM); + } tags[level].vlan_proto = VLAN_N_VID; return tags; } -- 2.43.0