From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 135B42C190; Thu, 18 Jan 2024 16:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705595854; cv=none; b=H0+COZe1g5Q3o+XjOxefzbWlZG/qzd/jNzjAiEmWVBvIDJdGMAfON3Oj0oahIbA+mWWpU5G98gBhTteSYQy71oRMzaiDxCeugkwKHSHOkkv05SI1e1P2LP9UNOj/QZQU3cJgIrQJAgGUNB9jiv+TMx4b7npkx7wHs+rdr8xhObE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705595854; c=relaxed/simple; bh=78qDvdoU8MNssGDZJwgtmCe+PdOvJ+qmDgSWEuv1VDQ=; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: In-Reply-To:References:MIME-Version:Content-Type: Content-Transfer-Encoding; b=JnNLgE2sZj6agODuHoX7DiEEao0ooNT8+TwSJuz83/kKh3g4MS4P1x6g1ehL1dPLCZBsZrq8rUytVSrVvEk5D8RGZtowhzhv3b8artoFhn8euvShf+1TMLPXKYOsoW35V+QG2kVViCGO8KAEmYfGIJjuiywbf1tdvVQmCZcz+sE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HPvXjPvT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HPvXjPvT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04491C433C7; Thu, 18 Jan 2024 16:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705595853; bh=78qDvdoU8MNssGDZJwgtmCe+PdOvJ+qmDgSWEuv1VDQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HPvXjPvTnBGU4VL398n3ldYn2txi+kr5JmTsgFrmJAwtS43X6azylVtz6ap+vsQs7 yHTvfVc6cRK1Xxifzd33twBhf3WGMdFq7a0CGJKhAe4eu4XSGoWg/kH+kEs+51uDoZ ScKotZl0BVYE8G2A9y34fy3DEBB9j09uSLdzagZTAq134QGpQEv0Zml3CDqWzYuZJj yRrAVtS4crcM7Fc+gxohEp4m8l4Pm8TQN3UTYwgyBFInh/WSk61c8s+25le/LyuBr0 Q++2IeFfQrX3qcGwyju5yUhvg5N+X6dDSjcPRKHcOr3rcc0uN9m4LkxH04EEq50ZqE cZ7iwqm2zzZtw== Date: Thu, 18 Jan 2024 08:37:30 -0800 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: Sebastian Andrzej Siewior , Alexei Starovoitov , LKML , Network Development , "David S. Miller" , Boqun Feng , Daniel Borkmann , Eric Dumazet , Frederic Weisbecker , Ingo Molnar , Paolo Abeni , Peter Zijlstra , Thomas Gleixner , Waiman Long , Will Deacon , Alexei Starovoitov , Andrii Nakryiko , Cong Wang , Hao Luo , Jamal Hadi Salim , Jesper Dangaard Brouer , Jiri Olsa , Jiri Pirko , John Fastabend , KP Singh , Martin KaFai Lau , Ronak Doshi , Song Liu , Stanislav Fomichev , VMware PV-Drivers Reviewers , Yonghong Song , bpf Subject: Re: [PATCH net-next 15/24] net: Use nested-BH locking for XDP redirect. Message-ID: <20240118083730.5e0166aa@kernel.org> In-Reply-To: <87bk9i6ert.fsf@toke.dk> References: <20231215171020.687342-1-bigeasy@linutronix.de> <20231215171020.687342-16-bigeasy@linutronix.de> <87r0iw524h.fsf@toke.dk> <20240112174138.tMmUs11o@linutronix.de> <87ttnb6hme.fsf@toke.dk> <20240117180447.2512335b@kernel.org> <87bk9i6ert.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 18 Jan 2024 12:51:18 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > I do agree that conceptually it makes a lot of sense to encapsulate the > budget like this so drivers don't have to do all this state tracking > themselves. It does appear that drivers are doing different things with > the budget as it is today, though. For instance, the intel drivers seem > to divide the budget over all the enabled RX rings(?); so I'm wondering > if it'll be possible to unify drivers around a more opaque NAPI poll API? We can come up with APIs which would cater to multi-queue cases. Bigger question is what is the sensible polling strategy for those, just dividing the budget seems, hm, crude.