From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <edumazet@google.com>
Cc: <davem@davemloft.net>, <eric.dumazet@gmail.com>,
<kuba@kernel.org>, <kuniyu@amazon.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>,
<syzbot+2a7024e9502df538e8ef@syzkaller.appspotmail.com>
Subject: Re: [PATCH net] llc: make llc_ui_sendmsg() more robust against bonding changes
Date: Thu, 18 Jan 2024 14:35:00 -0800 [thread overview]
Message-ID: <20240118223500.44066-1-kuniyu@amazon.com> (raw)
In-Reply-To: <CANn89i+=WbG00Qo9mqk4GuJjv0T9fEkgoDUCOXKVue-=_LAEsQ@mail.gmail.com>
From: Eric Dumazet <edumazet@google.com>
Date: Thu, 18 Jan 2024 23:14:21 +0100
> On Thu, Jan 18, 2024 at 10:59 PM Kuniyuki Iwashima <kuniyu@amazon.com> wrote:
> >
>
> > Probably we need not check SOCK_ZAPPED again after llc_ui_autobind() ?
> >
>
> Possibly, I was not sure if the socket could be disconnected or not.
>
> This would be a nop, or a correct check if disconnect is implemented.
>
> Do you see a problem with a strict validation ?
>
> I am tired of syzbot reports about llc, I want to add every possible checks.
Agreed, no problem.
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2024-01-18 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 18:36 [PATCH net] llc: make llc_ui_sendmsg() more robust against bonding changes Eric Dumazet
2024-01-18 21:58 ` Kuniyuki Iwashima
2024-01-18 22:14 ` Eric Dumazet
2024-01-18 22:35 ` Kuniyuki Iwashima [this message]
2024-01-20 5:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118223500.44066-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+2a7024e9502df538e8ef@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox