From: Simon Horman <horms@kernel.org>
To: Dmitry Safonov <dima@arista.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Mohammad Nassiri <mnassiri@ciena.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] selftests/net: Argument value mismatch when calling verify_counters()
Date: Fri, 19 Jan 2024 16:26:52 +0000 [thread overview]
Message-ID: <20240119162652.GG89683@kernel.org> (raw)
In-Reply-To: <20240118-tcp-ao-test-key-mgmt-v1-1-3583ca147113@arista.com>
On Thu, Jan 18, 2024 at 02:51:34AM +0000, Dmitry Safonov wrote:
> From: Mohammad Nassiri <mnassiri@ciena.com>
>
> The end_server() function only operates in the server thread
> and always takes an accept socket instead of a listen socket as
> its input argument. To align with this, invert the boolean values
> used when calling verify_counters() within the end_server() function.
Hi Dmitry,
I see that this is correct, but I am wondering
if it fixes a user-visible bug. If so, could
some text about that go here?
>
> Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test")
> Signed-off-by: Mohammad Nassiri <mnassiri@ciena.com>
> Link: https://lore.kernel.org/all/934627c5-eebb-4626-be23-cfb134c01d1a@arista.com/
> [amended 'Fixes' tag and carried-over to lkml]
> Signed-off-by: Dmitry Safonov <dima@arista.com>
...
next prev parent reply other threads:[~2024-01-19 16:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 2:51 [PATCH 0/3] selftests/net: A couple of typos fixes in key-management test Dmitry Safonov
2024-01-18 2:51 ` [PATCH 1/3] selftests/net: Argument value mismatch when calling verify_counters() Dmitry Safonov
2024-01-19 16:26 ` Simon Horman [this message]
2024-01-19 18:35 ` Dmitry Safonov
2024-01-18 2:51 ` [PATCH 2/3] selftests/net: Rectify key counters checks Dmitry Safonov
2024-01-18 2:51 ` [PATCH 3/3] selftests/net: Clean-up double assignment Dmitry Safonov
2024-01-19 16:25 ` Simon Horman
2024-01-19 18:37 ` Dmitry Safonov
2024-01-19 20:44 ` Simon Horman
2024-01-18 16:51 ` [PATCH 0/3] selftests/net: A couple of typos fixes in key-management test Jakub Kicinski
2024-01-18 17:04 ` Dmitry Safonov
2024-01-18 17:13 ` Jakub Kicinski
2024-01-19 18:39 ` Dmitry Safonov
2024-01-24 15:12 ` Jakub Kicinski
2024-01-24 17:46 ` Dmitry Safonov
2024-01-24 19:04 ` Jakub Kicinski
2024-01-24 19:59 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119162652.GG89683@kernel.org \
--to=horms@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mnassiri@ciena.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).