Re: [PATCH v5 iwl-next 1/6] ice: introduce PTP state machine

[Simon Horman <horms@kernel.org>]

On Wed, Jan 17, 2024 at 10:07:52PM +0000, Keller, Jacob E wrote:
> 
> 
> > -----Original Message-----
> > From: Simon Horman <horms@kernel.org>
> > Sent: Monday, January 15, 2024 2:33 AM
> > To: Kolacinski, Karol <karol.kolacinski@intel.com>
> > Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Nguyen, Anthony L
> > <anthony.l.nguyen@intel.com>; Brandeburg, Jesse
> > <jesse.brandeburg@intel.com>; Keller, Jacob E <jacob.e.keller@intel.com>
> > Subject: Re: [PATCH v5 iwl-next 1/6] ice: introduce PTP state machine
> > 
> > On Mon, Jan 08, 2024 at 01:47:12PM +0100, Karol Kolacinski wrote:
> > 
> > Should there be a "From: Jacob" line here to
> > match the Signed-off-by below?
> > 
> > > Add PTP state machine so that the driver can correctly identify PTP
> > > state around resets.
> > > When the driver got information about ungraceful reset, PTP was not
> > > prepared for reset and it returned error. When this situation occurs,
> > > prepare PTP before rebuilding its structures.
> > >
> > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> > > Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> > > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> > 
> > Hi Karol and Jacob,
> > 
> > FWIIW, The combination of both a Signed-off-by and Reviewed-by tag from
> > Jacob seems a little odd to me. If he authored the patch then I would have
> > gone with the following (along with the From line mentioned above):
> > 
> > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> > 
> > Otherwise, if he reviewed the patch I would have gone with:
> > 
> > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> > 
> 
> It's a bit odd, because I authored the initial code and patches some time ago, and Karol has been working to rebase and re-organize the code, so in some sense he authored part of this. I think a Co-authored would be suitable here. Additionally, I reviewed the result before it was published here.

Understood. I agree Co-authored might be useful here.