From: Christian Brauner <brauner@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
chuck.lever@oracle.com, jlayton@kernel.org,
linux-api@vger.kernel.org, edumazet@google.com,
davem@davemloft.net, alexander.duyck@gmail.com,
sridhar.samudrala@intel.com, kuba@kernel.org
Subject: Re: [RFC 1/1] eventpoll: support busy poll per epoll instance
Date: Mon, 22 Jan 2024 16:25:01 +0100 [thread overview]
Message-ID: <20240122-erwidern-erleichtern-8a04080a4db3@brauner> (raw)
In-Reply-To: <20240120004247.42036-2-jdamato@fastly.com>
On Sat, Jan 20, 2024 at 12:42:47AM +0000, Joe Damato wrote:
> Add F_EPOLL_{S,G}ET_BUSY_POLL_USECS to allow setting a busy poll timeout
> per epoll instance so that individual applications can enable (or
> disable) epoll based busy poll as needed.
>
> Prior to this change, epoll-based busy poll could only be enabled
> system-wide, which limits the usefulness of busy poll.
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> ---
This should be an ioctl on the epoll fd, not a fcntl(). fcntl()s
should aim to be generic which this isn't. We've recently rejected a
memfd addition as a fcntl() as well for the same reason.
next prev parent reply other threads:[~2024-01-22 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 0:42 [RFC 0/1] RFC: Allow busy poll to be set per epoll instance Joe Damato
2024-01-20 0:42 ` [RFC 1/1] eventpoll: support busy poll " Joe Damato
2024-01-22 15:25 ` Christian Brauner [this message]
2024-01-22 21:16 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122-erwidern-erleichtern-8a04080a4db3@brauner \
--to=brauner@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=jlayton@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox