From: Vladimir Oltean <olteanv@gmail.com>
To: Tim Menninger <tmenninger@purestorage.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Make *_c45 callbacks agree with phy_*_c45 callbacks
Date: Mon, 22 Jan 2024 14:33:49 +0200 [thread overview]
Message-ID: <20240122123349.cxx2i2kzrhuqnasp@skbuf> (raw)
In-Reply-To: <CAO-L_46kqBrDdYP7p3He0cBF1OP7TJKnhYK1NR_gMZf2n_928A@mail.gmail.com>
On Tue, Jan 16, 2024 at 05:51:13PM -0800, Tim Menninger wrote:
> My impression is still that the read_c45 function should agree with the
> phy_read_c45 function, but that isn't a hill I care to die on if you still
> think otherwise. Thoughts?
FWIW, Tim's approach is consistent with what drivers/net/mdio/mdio-mux.c does.
if (parent_bus->read)
cb->mii_bus->read = mdio_mux_read;
if (parent_bus->write)
cb->mii_bus->write = mdio_mux_write;
if (parent_bus->read_c45)
cb->mii_bus->read_c45 = mdio_mux_read_c45;
if (parent_bus->write_c45)
cb->mii_bus->write_c45 = mdio_mux_write_c45;
My only objection to his patch (apart from the commit message which
should indeed be more detailed) is that I would have preferred the same
"if" syntax rather than the use of a ternary operator with NULL.
next prev parent reply other threads:[~2024-01-22 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 19:35 [PATCH] net: dsa: mv88e6xxx: Make *_c45 callbacks agree with phy_*_c45 callbacks Tim Menninger
2024-01-16 19:59 ` Andrew Lunn
2024-01-16 22:24 ` Tim Menninger
2024-01-16 23:21 ` Andrew Lunn
2024-01-17 1:51 ` Tim Menninger
2024-01-22 12:33 ` Vladimir Oltean [this message]
2024-01-22 14:30 ` Andrew Lunn
2024-01-22 15:12 ` Vladimir Oltean
2024-01-22 15:46 ` Tim Menninger
2024-01-23 15:27 ` Vladimir Oltean
2024-01-29 18:53 ` Tim Menninger
2024-01-29 18:55 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122123349.cxx2i2kzrhuqnasp@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tmenninger@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox