netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v1 net] selftest: Don't reuse port for SO_INCOMING_CPU test.
Date: Mon, 22 Jan 2024 13:13:38 -0800	[thread overview]
Message-ID: <20240122131338.7c691d32@kernel.org> (raw)
In-Reply-To: <20240120031642.67014-1-kuniyu@amazon.com>

On Fri, 19 Jan 2024 19:16:42 -0800 Kuniyuki Iwashima wrote:
> Jakub reported that ASSERT_EQ(cpu, i) in so_incoming_cpu.c seems to
> fire somewhat randomly.
> 
>   # #  RUN           so_incoming_cpu.before_reuseport.test3 ...
>   # # so_incoming_cpu.c:191:test3:Expected cpu (32) == i (0)
>   # # test3: Test terminated by assertion
>   # #          FAIL  so_incoming_cpu.before_reuseport.test3
>   # not ok 3 so_incoming_cpu.before_reuseport.test3
> 
> When the test failed, not-yet-accepted CLOSE_WAIT sockets received
> SYN with a "challenging" SEQ number, which was sent from an unexpected
> CPU that did not create the receiver.

Tested-by: Jakub Kicinski <kuba@kernel.org>

Thanks for a quick fix!

  reply	other threads:[~2024-01-22 21:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20  3:16 [PATCH v1 net] selftest: Don't reuse port for SO_INCOMING_CPU test Kuniyuki Iwashima
2024-01-22 21:13 ` Jakub Kicinski [this message]
2024-01-23 10:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240122131338.7c691d32@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).