From: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Dimitri Fedrau <dima.fedrau@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Stefan Eichenberger <eichest@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 net-next 11/13] net: phy: marvell-88q2xxx: switch to mv88q2xxx_config_aneg
Date: Mon, 22 Jan 2024 22:28:44 +0100 [thread overview]
Message-ID: <20240122212848.3645785-12-dima.fedrau@gmail.com> (raw)
In-Reply-To: <20240122212848.3645785-1-dima.fedrau@gmail.com>
Switch to mv88q2xxx_config_aneg for Marvell 88Q2220 devices and remove
the mv88q222x_config_aneg function which is basically a copy of the
mv88q2xxx_config_aneg function.
Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
---
drivers/net/phy/marvell-88q2xxx.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/net/phy/marvell-88q2xxx.c b/drivers/net/phy/marvell-88q2xxx.c
index 8bd68b3c3ea1..e40ea351fcde 100644
--- a/drivers/net/phy/marvell-88q2xxx.c
+++ b/drivers/net/phy/marvell-88q2xxx.c
@@ -688,17 +688,6 @@ static int mv88q222x_soft_reset(struct phy_device *phydev)
return 0;
}
-static int mv88q222x_config_aneg(struct phy_device *phydev)
-{
- int ret;
-
- ret = genphy_c45_config_aneg(phydev);
- if (ret)
- return ret;
-
- return mv88q222x_soft_reset(phydev);
-}
-
static int mv88q222x_revb0_config_init(struct phy_device *phydev)
{
int ret, i;
@@ -833,7 +822,7 @@ static struct phy_driver mv88q2xxx_driver[] = {
.flags = PHY_POLL_CABLE_TEST,
.probe = mv88q2xxx_probe,
.get_features = mv88q2xxx_get_features,
- .config_aneg = mv88q222x_config_aneg,
+ .config_aneg = mv88q2xxx_config_aneg,
.aneg_done = genphy_c45_aneg_done,
.config_init = mv88q222x_revb0_config_init,
.read_status = mv88q2xxx_read_status,
--
2.39.2
next prev parent reply other threads:[~2024-01-22 21:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 21:28 [PATCH v5 net-next 00/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 01/13] net: phy: Add BaseT1 auto-negotiation constants Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 02/13] net: phy: Support 100/1000BT1 linkmode advertisements Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 03/13] net: phy: c45: detect 100/1000BASE-T1 " Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 04/13] net: phy: marvell-88q2xxx: fix typos Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 05/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Dimitri Fedrau
2024-01-31 15:08 ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 06/13] net: phy: marvell-88q2xxx: add interrupt support for link detection Dimitri Fedrau
2024-01-31 15:12 ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 07/13] net: phy: marvell-88q2xxx: add suspend / resume ops Dimitri Fedrau
2024-01-31 15:12 ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 08/13] net: phy: marvell-88q2xxx: add support for temperature sensor Dimitri Fedrau
2024-01-30 9:18 ` Russell King (Oracle)
2024-01-31 11:52 ` Dimitri Fedrau
2024-01-31 15:17 ` Andrew Lunn
2024-02-01 7:11 ` Dimitri Fedrau
2024-02-01 13:23 ` Andrew Lunn
2024-02-01 16:52 ` Dimitri Fedrau
2024-02-01 13:34 ` Guenter Roeck
2024-02-01 16:14 ` Dimitri Fedrau
2024-02-01 18:26 ` Guenter Roeck
2024-02-01 13:18 ` Guenter Roeck
2024-02-01 13:27 ` Andrew Lunn
2024-02-01 13:39 ` Guenter Roeck
2024-02-01 16:23 ` Dimitri Fedrau
2024-02-01 16:47 ` Andrew Lunn
2024-02-01 16:56 ` Dimitri Fedrau
2024-02-01 18:22 ` Guenter Roeck
2024-02-01 16:17 ` Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 09/13] net: phy: marvell-88q2xxx: add cable test support Dimitri Fedrau
2024-01-30 9:19 ` Russell King (Oracle)
2024-01-31 12:03 ` Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 10/13] net: phy: marvell-88q2xxx: make mv88q2xxx_config_aneg generic Dimitri Fedrau
2024-01-31 15:19 ` Andrew Lunn
2024-01-22 21:28 ` Dimitri Fedrau [this message]
2024-01-31 15:20 ` [PATCH v5 net-next 11/13] net: phy: marvell-88q2xxx: switch to mv88q2xxx_config_aneg Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 12/13] net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init Dimitri Fedrau
2024-01-31 15:21 ` Andrew Lunn
2024-02-02 17:19 ` Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 13/13] net: phy: marvell-88q2xxx: remove redundant code Dimitri Fedrau
2024-01-30 2:09 ` [PATCH v5 net-next 00/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Jakub Kicinski
2024-02-02 18:30 ` Dimitri Fedrau
2024-02-03 16:07 ` Andrew Lunn
2024-02-05 9:32 ` Dimitri Fedrau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122212848.3645785-12-dima.fedrau@gmail.com \
--to=dima.fedrau@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).