From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <edumazet@google.com>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
<eric.dumazet@gmail.com>, <gnault@redhat.com>, <kafai@fb.com>,
<kuba@kernel.org>, <kuniyu@amazon.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/9] sock_diag: annotate data-races around sock_diag_handlers[family]
Date: Mon, 22 Jan 2024 14:36:36 -0800 [thread overview]
Message-ID: <20240122223636.19548-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20240122112603.3270097-2-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 22 Jan 2024 11:25:55 +0000
> __sock_diag_cmd() and sock_diag_bind() read sock_diag_handlers[family]
> without a lock held.
>
> Use READ_ONCE()/WRITE_ONCE() annotations to avoid potential issues.
>
> Fixes: 8ef874bfc729 ("sock_diag: Move the sock_ code to net/core/")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2024-01-22 22:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 11:25 [PATCH net-next 0/9] inet_diag: remove three mutexes in diag dumps Eric Dumazet
2024-01-22 11:25 ` [PATCH net-next 1/9] sock_diag: annotate data-races around sock_diag_handlers[family] Eric Dumazet
2024-01-22 16:29 ` Guillaume Nault
2024-01-22 22:36 ` Kuniyuki Iwashima [this message]
2024-01-22 11:25 ` [PATCH net-next 2/9] inet_diag: annotate data-races around inet_diag_table[] Eric Dumazet
2024-01-22 16:29 ` Guillaume Nault
2024-01-22 22:37 ` Kuniyuki Iwashima
2024-01-22 11:25 ` [PATCH net-next 3/9] inet_diag: add module pointer to "struct inet_diag_handler" Eric Dumazet
2024-01-22 16:58 ` Guillaume Nault
2024-01-22 22:38 ` Kuniyuki Iwashima
2024-01-22 11:25 ` [PATCH net-next 4/9] inet_diag: allow concurrent operations Eric Dumazet
2024-01-22 16:58 ` Guillaume Nault
2024-01-22 22:40 ` Kuniyuki Iwashima
2024-01-22 11:25 ` [PATCH net-next 5/9] sock_diag: add module pointer to "struct sock_diag_handler" Eric Dumazet
2024-01-22 17:24 ` Guillaume Nault
2024-01-22 22:44 ` Kuniyuki Iwashima
2024-01-22 11:26 ` [PATCH net-next 6/9] sock_diag: allow concurrent operations Eric Dumazet
2024-01-22 17:25 ` Guillaume Nault
2024-01-22 22:47 ` Kuniyuki Iwashima
2024-01-22 11:26 ` [PATCH net-next 7/9] sock_diag: allow concurrent operation in sock_diag_rcv_msg() Eric Dumazet
2024-01-22 17:25 ` Guillaume Nault
2024-01-22 22:51 ` Kuniyuki Iwashima
2024-01-22 11:26 ` [PATCH net-next 8/9] sock_diag: remove sock_diag_mutex Eric Dumazet
2024-01-22 21:38 ` Guillaume Nault
2024-01-22 22:55 ` Kuniyuki Iwashima
2024-01-22 11:26 ` [PATCH net-next 9/9] inet_diag: skip over empty buckets Eric Dumazet
2024-01-22 21:44 ` Guillaume Nault
2024-01-22 22:58 ` Kuniyuki Iwashima
2024-01-22 15:05 ` [PATCH net-next 0/9] inet_diag: remove three mutexes in diag dumps Willem de Bruijn
2024-01-23 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122223636.19548-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gnault@redhat.com \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).