From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: Paolo Abeni <pabeni@redhat.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
shuah@kernel.org, horms@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: netdevsim: fix the udp_tunnel_nic test
Date: Tue, 23 Jan 2024 07:42:50 -0800 [thread overview]
Message-ID: <20240123074250.60b2b232@kernel.org> (raw)
In-Reply-To: <20240123073925.416d3746@kernel.org>
On Tue, 23 Jan 2024 07:39:25 -0800 Jakub Kicinski wrote:
> On Tue, 23 Jan 2024 09:27:17 +0100 Paolo Abeni wrote:
> > > @@ -270,6 +270,7 @@ for port in 0 1; do
> > > echo 1 > $NSIM_DEV_SYS/new_port
> > > fi
> > > NSIM_NETDEV=`get_netdev_name old_netdevs`
> > > + ifconfig $NSIM_NETDEV up
> >
> > WoW! I initially thought the above was a typo, before noticing it's
> > actually consistent with the whole script :)
> >
> > Do you think we should look at dropping ifconfig usage from self-tests?
> > I guess that in the long run most systems should not have such command
> > available in the default install.
>
> Good point, there's only one use outside of this script.
> I'll queue up a conversion for -next!
Hm, Hi Florian! Is the use of ifconfig in kci_test_promote_secondaries,
commit bb2bd090854cc6 on purpose or can I switch that to ip addr, too?
next prev parent reply other threads:[~2024-01-23 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 6:05 [PATCH net] selftests: netdevsim: fix the udp_tunnel_nic test Jakub Kicinski
2024-01-23 8:27 ` Paolo Abeni
2024-01-23 15:39 ` Jakub Kicinski
2024-01-23 15:42 ` Jakub Kicinski [this message]
2024-01-24 10:19 ` Simon Horman
2024-01-24 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123074250.60b2b232@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).