[PATCH net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb

[PATCH net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb

[Hangbin Liu]

The prio_arp/ns tests hard code the mode to active-backup. At the same
time, The balance-alb/tlb modes do not support arp/ns target. So remove
the prio_arp/ns tests from the loop and only test active-backup mode.

Fixes: 481b56e0391e ("selftests: bonding: re-format bond option tests")
Reported-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 .../testing/selftests/drivers/net/bonding/bond_options.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/drivers/net/bonding/bond_options.sh b/tools/testing/selftests/drivers/net/bonding/bond_options.sh
index c54d1697f439..d508486cc0bd 100755
--- a/tools/testing/selftests/drivers/net/bonding/bond_options.sh
+++ b/tools/testing/selftests/drivers/net/bonding/bond_options.sh
@@ -162,7 +162,7 @@ prio_arp()
 	local mode=$1
 
 	for primary_reselect in 0 1 2; do
-		prio_test "mode active-backup arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
+		prio_test "mode $mode arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
 		log_test "prio" "$mode arp_ip_target primary_reselect $primary_reselect"
 	done
 }
@@ -178,7 +178,7 @@ prio_ns()
 	fi
 
 	for primary_reselect in 0 1 2; do
-		prio_test "mode active-backup arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
+		prio_test "mode $mode arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
 		log_test "prio" "$mode ns_ip6_target primary_reselect $primary_reselect"
 	done
 }
@@ -194,9 +194,9 @@ prio()
 
 	for mode in $modes; do
 		prio_miimon $mode
-		prio_arp $mode
-		prio_ns $mode
 	done
+	prio_arp "active-backup"
+	prio_ns "active-backup"
 }
 
 arp_validate_test()
-- 
2.43.0

Re: [PATCH net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb

[Jay Vosburgh]

Hangbin Liu <liuhangbin@gmail.com> wrote:

>The prio_arp/ns tests hard code the mode to active-backup. At the same
>time, The balance-alb/tlb modes do not support arp/ns target. So remove
>the prio_arp/ns tests from the loop and only test active-backup mode.
>
>Fixes: 481b56e0391e ("selftests: bonding: re-format bond option tests")
>Reported-by: Jay Vosburgh <jay.vosburgh@canonical.com>
>Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/
>Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>


>---
> .../testing/selftests/drivers/net/bonding/bond_options.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/tools/testing/selftests/drivers/net/bonding/bond_options.sh b/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>index c54d1697f439..d508486cc0bd 100755
>--- a/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>+++ b/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>@@ -162,7 +162,7 @@ prio_arp()
> 	local mode=$1
> 
> 	for primary_reselect in 0 1 2; do
>-		prio_test "mode active-backup arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
>+		prio_test "mode $mode arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
> 		log_test "prio" "$mode arp_ip_target primary_reselect $primary_reselect"
> 	done
> }
>@@ -178,7 +178,7 @@ prio_ns()
> 	fi
> 
> 	for primary_reselect in 0 1 2; do
>-		prio_test "mode active-backup arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
>+		prio_test "mode $mode arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
> 		log_test "prio" "$mode ns_ip6_target primary_reselect $primary_reselect"
> 	done
> }
>@@ -194,9 +194,9 @@ prio()
> 
> 	for mode in $modes; do
> 		prio_miimon $mode
>-		prio_arp $mode
>-		prio_ns $mode
> 	done
>+	prio_arp "active-backup"
>+	prio_ns "active-backup"
> }
> 
> arp_validate_test()
>-- 
>2.43.0
>

Re: [PATCH net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 23 Jan 2024 15:59:17 +0800 you wrote:
> The prio_arp/ns tests hard code the mode to active-backup. At the same
> time, The balance-alb/tlb modes do not support arp/ns target. So remove
> the prio_arp/ns tests from the loop and only test active-backup mode.
> 
> Fixes: 481b56e0391e ("selftests: bonding: re-format bond option tests")
> Reported-by: Jay Vosburgh <jay.vosburgh@canonical.com>
> Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb
    https://git.kernel.org/netdev/net/c/a2933a8759a6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html