* [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2)
@ 2024-01-23 19:03 Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 01/10] net: fill in MODULE_DESCRIPTION()s for 8390 Breno Leitao
` (10 more replies)
0 siblings, 11 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet; +Cc: dsahern, weiwan, netdev, linux-kernel
There are hundreds of network modules that misses MODULE_DESCRIPTION(),
causing a warnning when compiling with W=1. Example:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o
This part2 of the patchset focus on the drivers/net/ethernet drivers.
There are still some missing warnings in drivers/net/ethernet that will
be fixed in an upcoming patchset.
Changelog:
---------
V1:
* https://lore.kernel.org/all/20240122184543.2501493-2-leitao@debian.org/
V2:
* Limit the patchset to 10 patches.
* Rewrite the following module description:
* fec
* bgmac
* Added acknowledge in the following driver:
* litex
Breno Leitao (10):
net: fill in MODULE_DESCRIPTION()s for 8390
net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac
net: fill in MODULE_DESCRIPTION()s for liquidio
net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth
net: fill in MODULE_DESCRIPTION()s for nps_enet
net: fill in MODULE_DESCRIPTION()s for enetc
net: fill in MODULE_DESCRIPTION()s for fec
net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio
net: fill in MODULE_DESCRIPTION()s for litex
net: fill in MODULE_DESCRIPTION()s for rvu_mbox
drivers/net/ethernet/8390/8390.c | 1 +
drivers/net/ethernet/8390/8390p.c | 1 +
drivers/net/ethernet/8390/apne.c | 1 +
drivers/net/ethernet/8390/hydra.c | 1 +
drivers/net/ethernet/8390/stnic.c | 1 +
drivers/net/ethernet/8390/zorro8390.c | 1 +
drivers/net/ethernet/broadcom/bcm4908_enet.c | 1 +
drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
drivers/net/ethernet/broadcom/bgmac-bcma.c | 1 +
drivers/net/ethernet/broadcom/bgmac-platform.c | 1 +
drivers/net/ethernet/broadcom/bgmac.c | 1 +
drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 +
drivers/net/ethernet/cirrus/ep93xx_eth.c | 1 +
drivers/net/ethernet/ezchip/nps_enet.c | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 1 +
drivers/net/ethernet/freescale/fec_main.c | 1 +
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 1 +
drivers/net/ethernet/litex/litex_liteeth.c | 1 +
drivers/net/ethernet/marvell/octeontx2/af/mbox.c | 1 +
19 files changed, 19 insertions(+)
--
2.39.3
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH net v2 01/10] net: fill in MODULE_DESCRIPTION()s for 8390
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 02/10] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac Breno Leitao
` (9 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet
Cc: dsahern, weiwan, netdev, linux-kernel, geert, Greg Ungerer,
Bagas Sanjaya
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to all the good old 8390 modules and drivers.
Signed-off-by: Breno Leitao <leitao@debian.org>
CC: geert@linux-m68k.org
---
drivers/net/ethernet/8390/8390.c | 1 +
drivers/net/ethernet/8390/8390p.c | 1 +
drivers/net/ethernet/8390/apne.c | 1 +
drivers/net/ethernet/8390/hydra.c | 1 +
drivers/net/ethernet/8390/stnic.c | 1 +
drivers/net/ethernet/8390/zorro8390.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/8390/8390.c b/drivers/net/ethernet/8390/8390.c
index 0e0aa4016858..c5636245f1ca 100644
--- a/drivers/net/ethernet/8390/8390.c
+++ b/drivers/net/ethernet/8390/8390.c
@@ -100,4 +100,5 @@ static void __exit ns8390_module_exit(void)
module_init(ns8390_module_init);
module_exit(ns8390_module_exit);
#endif /* MODULE */
+MODULE_DESCRIPTION("National Semiconductor 8390 core driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/8390p.c b/drivers/net/ethernet/8390/8390p.c
index 6834742057b3..6d429b11e9c6 100644
--- a/drivers/net/ethernet/8390/8390p.c
+++ b/drivers/net/ethernet/8390/8390p.c
@@ -102,4 +102,5 @@ static void __exit NS8390p_cleanup_module(void)
module_init(NS8390p_init_module);
module_exit(NS8390p_cleanup_module);
+MODULE_DESCRIPTION("National Semiconductor 8390 core for ISA driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/apne.c b/drivers/net/ethernet/8390/apne.c
index a09f383dd249..828edca8d30c 100644
--- a/drivers/net/ethernet/8390/apne.c
+++ b/drivers/net/ethernet/8390/apne.c
@@ -610,4 +610,5 @@ static int init_pcmcia(void)
return 1;
}
+MODULE_DESCRIPTION("National Semiconductor 8390 Amiga PCMCIA ethernet driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/hydra.c b/drivers/net/ethernet/8390/hydra.c
index 24f49a8ff903..fd9dcdc356e6 100644
--- a/drivers/net/ethernet/8390/hydra.c
+++ b/drivers/net/ethernet/8390/hydra.c
@@ -270,4 +270,5 @@ static void __exit hydra_cleanup_module(void)
module_init(hydra_init_module);
module_exit(hydra_cleanup_module);
+MODULE_DESCRIPTION("Zorro-II Hydra 8390 ethernet driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/stnic.c b/drivers/net/ethernet/8390/stnic.c
index 265976e3b64a..6cc0e190aa79 100644
--- a/drivers/net/ethernet/8390/stnic.c
+++ b/drivers/net/ethernet/8390/stnic.c
@@ -296,4 +296,5 @@ static void __exit stnic_cleanup(void)
module_init(stnic_probe);
module_exit(stnic_cleanup);
+MODULE_DESCRIPTION("National Semiconductor DP83902AV ethernet driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/8390/zorro8390.c b/drivers/net/ethernet/8390/zorro8390.c
index d70390e9d03d..c24dd4fe7a10 100644
--- a/drivers/net/ethernet/8390/zorro8390.c
+++ b/drivers/net/ethernet/8390/zorro8390.c
@@ -443,4 +443,5 @@ static void __exit zorro8390_cleanup_module(void)
module_init(zorro8390_init_module);
module_exit(zorro8390_cleanup_module);
+MODULE_DESCRIPTION("Zorro NS8390-based ethernet driver");
MODULE_LICENSE("GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 02/10] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 01/10] net: fill in MODULE_DESCRIPTION()s for 8390 Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-23 19:27 ` Florian Fainelli
2024-01-23 19:03 ` [PATCH net v2 03/10] net: fill in MODULE_DESCRIPTION()s for liquidio Breno Leitao
` (8 subsequent siblings)
10 siblings, 1 reply; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Rafał Miłecki,
Broadcom internal kernel review list
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Broadcom iProc GBit driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/broadcom/bcm4908_enet.c | 1 +
drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
drivers/net/ethernet/broadcom/bgmac-bcma.c | 1 +
drivers/net/ethernet/broadcom/bgmac-platform.c | 1 +
drivers/net/ethernet/broadcom/bgmac.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
index 3e7c8671cd11..72df1bb10172 100644
--- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
@@ -793,5 +793,6 @@ static struct platform_driver bcm4908_enet_driver = {
};
module_platform_driver(bcm4908_enet_driver);
+MODULE_DESCRIPTION("Broadcom BCM4908 Gigabit Ethernet driver");
MODULE_LICENSE("GPL v2");
MODULE_DEVICE_TABLE(of, bcm4908_enet_of_match);
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c b/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
index 9b83d5361699..50b8e97a811d 100644
--- a/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c
@@ -260,4 +260,5 @@ void bcma_mdio_mii_unregister(struct mii_bus *mii_bus)
EXPORT_SYMBOL_GPL(bcma_mdio_mii_unregister);
MODULE_AUTHOR("Rafał Miłecki");
+MODULE_DESCRIPTION("Broadcom iProc GBit BCMA MDIO helpers");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c
index 6e4f36aaf5db..36f9bad28e6a 100644
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
@@ -362,4 +362,5 @@ module_init(bgmac_init)
module_exit(bgmac_exit)
MODULE_AUTHOR("Rafał Miłecki");
+MODULE_DESCRIPTION("Broadcom iProc GBit BCMA interface driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c
index 0b21fd5bd457..77425c7a32db 100644
--- a/drivers/net/ethernet/broadcom/bgmac-platform.c
+++ b/drivers/net/ethernet/broadcom/bgmac-platform.c
@@ -298,4 +298,5 @@ static struct platform_driver bgmac_enet_driver = {
};
module_platform_driver(bgmac_enet_driver);
+MODULE_DESCRIPTION("Broadcom iProc GBit platform interface driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 448a1b90de5e..6ffdc4229407 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1626,4 +1626,5 @@ int bgmac_enet_resume(struct bgmac *bgmac)
EXPORT_SYMBOL_GPL(bgmac_enet_resume);
MODULE_AUTHOR("Rafał Miłecki");
+MODULE_DESCRIPTION("Broadcom iProc GBit driver");
MODULE_LICENSE("GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 03/10] net: fill in MODULE_DESCRIPTION()s for liquidio
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 01/10] net: fill in MODULE_DESCRIPTION()s for 8390 Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 02/10] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 04/10] net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth Breno Leitao
` (7 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet
Cc: dsahern, weiwan, netdev, linux-kernel, Masahiro Yamada,
Simon Horman
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Cavium Liquidio.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
index 9cc6303c82ff..f38d31bfab1b 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
@@ -27,6 +27,7 @@
#include "octeon_network.h"
MODULE_AUTHOR("Cavium Networks, <support@cavium.com>");
+MODULE_DESCRIPTION("Cavium LiquidIO Intelligent Server Adapter Core");
MODULE_LICENSE("GPL");
/* OOM task polling interval */
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 04/10] net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
` (2 preceding siblings ...)
2024-01-23 19:03 ` [PATCH net v2 03/10] net: fill in MODULE_DESCRIPTION()s for liquidio Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 05/10] net: fill in MODULE_DESCRIPTION()s for nps_enet Breno Leitao
` (6 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Hartley Sweeten
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Cirrus EP93xx ethernet driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/cirrus/ep93xx_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c
index 1c2a540db13d..1f495cfd7959 100644
--- a/drivers/net/ethernet/cirrus/ep93xx_eth.c
+++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c
@@ -868,5 +868,6 @@ static struct platform_driver ep93xx_eth_driver = {
module_platform_driver(ep93xx_eth_driver);
+MODULE_DESCRIPTION("Cirrus EP93xx Ethernet driver");
MODULE_LICENSE("GPL");
MODULE_ALIAS("platform:ep93xx-eth");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 05/10] net: fill in MODULE_DESCRIPTION()s for nps_enet
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
` (3 preceding siblings ...)
2024-01-23 19:03 ` [PATCH net v2 04/10] net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 06/10] net: fill in MODULE_DESCRIPTION()s for enetc Breno Leitao
` (5 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet
Cc: dsahern, weiwan, netdev, linux-kernel, Bhupesh Sharma,
Rob Herring, Christian Marangi, Uwe Kleine-König
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the EZchip NPS ethernet driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/ezchip/nps_enet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c
index 07c2b701b5fa..9ebe751c1df0 100644
--- a/drivers/net/ethernet/ezchip/nps_enet.c
+++ b/drivers/net/ethernet/ezchip/nps_enet.c
@@ -661,4 +661,5 @@ static struct platform_driver nps_enet_driver = {
module_platform_driver(nps_enet_driver);
MODULE_AUTHOR("EZchip Semiconductor");
+MODULE_DESCRIPTION("EZchip NPS Ethernet driver");
MODULE_LICENSE("GPL v2");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 06/10] net: fill in MODULE_DESCRIPTION()s for enetc
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
` (4 preceding siblings ...)
2024-01-23 19:03 ` [PATCH net v2 05/10] net: fill in MODULE_DESCRIPTION()s for nps_enet Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 07/10] net: fill in MODULE_DESCRIPTION()s for fec Breno Leitao
` (4 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Claudiu Manoil, Vladimir Oltean
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the NXP ENETC Ethernet driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/freescale/enetc/enetc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index cffbf27c4656..bfdbdab443ae 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -3216,4 +3216,5 @@ void enetc_pci_remove(struct pci_dev *pdev)
}
EXPORT_SYMBOL_GPL(enetc_pci_remove);
+MODULE_DESCRIPTION("NXP ENETC Ethernet driver");
MODULE_LICENSE("Dual BSD/GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 07/10] net: fill in MODULE_DESCRIPTION()s for fec
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
` (5 preceding siblings ...)
2024-01-23 19:03 ` [PATCH net v2 06/10] net: fill in MODULE_DESCRIPTION()s for enetc Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-24 1:13 ` Wei Fang
2024-01-23 19:03 ` [PATCH net v2 08/10] net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio Breno Leitao
` (3 subsequent siblings)
10 siblings, 1 reply; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Wei Fang, Shenwei Wang, Clark Wang,
NXP Linux Team
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the FEC (MPC8xx) Ethernet controller.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/freescale/fec_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index d42594f32275..4b0259e9269a 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = {
module_platform_driver(fec_driver);
+MODULE_DESCRIPTION("NXP Fast Ethernet Controller (FEC) driver");
MODULE_LICENSE("GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 08/10] net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
` (6 preceding siblings ...)
2024-01-23 19:03 ` [PATCH net v2 07/10] net: fill in MODULE_DESCRIPTION()s for fec Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 09/10] net: fill in MODULE_DESCRIPTION()s for litex Breno Leitao
` (2 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet
Cc: dsahern, weiwan, netdev, linux-kernel, Rob Herring, Simon Horman,
Alex Elder, Uwe Kleine-König
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Freescale PQ MDIO driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index 70dd982a5edc..026f7270a54d 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -531,4 +531,5 @@ static struct platform_driver fsl_pq_mdio_driver = {
module_platform_driver(fsl_pq_mdio_driver);
+MODULE_DESCRIPTION("Freescale PQ MDIO helpers");
MODULE_LICENSE("GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 09/10] net: fill in MODULE_DESCRIPTION()s for litex
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
` (7 preceding siblings ...)
2024-01-23 19:03 ` [PATCH net v2 08/10] net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 10/10] net: fill in MODULE_DESCRIPTION()s for rvu_mbox Breno Leitao
2024-01-24 23:20 ` [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) patchwork-bot+netdevbpf
10 siblings, 0 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Karol Gugala, Mateusz Holenko,
Gabriel Somlo, Joel Stanley
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LiteX Liteeth Ethernet device.
Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Gabriel Somlo <gsomlo@gmail.com>
---
drivers/net/ethernet/litex/litex_liteeth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
index 5182fe737c37..ff54fbe41bcc 100644
--- a/drivers/net/ethernet/litex/litex_liteeth.c
+++ b/drivers/net/ethernet/litex/litex_liteeth.c
@@ -318,4 +318,5 @@ static struct platform_driver liteeth_driver = {
module_platform_driver(liteeth_driver);
MODULE_AUTHOR("Joel Stanley <joel@jms.id.au>");
+MODULE_DESCRIPTION("LiteX Liteeth Ethernet driver");
MODULE_LICENSE("GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net v2 10/10] net: fill in MODULE_DESCRIPTION()s for rvu_mbox
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
` (8 preceding siblings ...)
2024-01-23 19:03 ` [PATCH net v2 09/10] net: fill in MODULE_DESCRIPTION()s for litex Breno Leitao
@ 2024-01-23 19:03 ` Breno Leitao
2024-01-24 23:20 ` [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) patchwork-bot+netdevbpf
10 siblings, 0 replies; 14+ messages in thread
From: Breno Leitao @ 2024-01-23 19:03 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Sunil Goutham, Linu Cherian,
Geetha sowjanya, Jerin Jacob, hariprasad, Subbaraya Sundeep
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Marvel RVU mbox driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/marvell/octeontx2/af/mbox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mbox.c b/drivers/net/ethernet/marvell/octeontx2/af/mbox.c
index 9690ac01f02c..b92264d0a77e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/mbox.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/mbox.c
@@ -413,4 +413,5 @@ const char *otx2_mbox_id2name(u16 id)
EXPORT_SYMBOL(otx2_mbox_id2name);
MODULE_AUTHOR("Marvell.");
+MODULE_DESCRIPTION("Marvell RVU NIC Mbox helpers");
MODULE_LICENSE("GPL v2");
--
2.39.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net v2 02/10] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac
2024-01-23 19:03 ` [PATCH net v2 02/10] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac Breno Leitao
@ 2024-01-23 19:27 ` Florian Fainelli
0 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2024-01-23 19:27 UTC (permalink / raw)
To: Breno Leitao, kuba, davem, pabeni, edumazet,
Rafał Miłecki, Broadcom internal kernel review list
Cc: dsahern, weiwan, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On 1/23/24 11:03, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Broadcom iProc GBit driver.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH net v2 07/10] net: fill in MODULE_DESCRIPTION()s for fec
2024-01-23 19:03 ` [PATCH net v2 07/10] net: fill in MODULE_DESCRIPTION()s for fec Breno Leitao
@ 2024-01-24 1:13 ` Wei Fang
0 siblings, 0 replies; 14+ messages in thread
From: Wei Fang @ 2024-01-24 1:13 UTC (permalink / raw)
To: Breno Leitao, kuba@kernel.org, davem@davemloft.net,
pabeni@redhat.com, edumazet@google.com, Shenwei Wang, Clark Wang,
dl-linux-imx
Cc: dsahern@kernel.org, weiwan@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Breno Leitao <leitao@debian.org>
> Sent: 2024年1月24日 3:03
> To: kuba@kernel.org; davem@davemloft.net; pabeni@redhat.com;
> edumazet@google.com; Wei Fang <wei.fang@nxp.com>; Shenwei Wang
> <shenwei.wang@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>;
> dl-linux-imx <linux-imx@nxp.com>
> Cc: dsahern@kernel.org; weiwan@google.com; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH net v2 07/10] net: fill in MODULE_DESCRIPTION()s for fec
>
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the FEC (MPC8xx) Ethernet controller.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d42594f32275..4b0259e9269a 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = {
>
> module_platform_driver(fec_driver);
>
> +MODULE_DESCRIPTION("NXP Fast Ethernet Controller (FEC) driver");
> MODULE_LICENSE("GPL");
> --
> 2.39.3
Thanks!
Reviewed-by: Wei Fang <wei.fang@nxp.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2)
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
` (9 preceding siblings ...)
2024-01-23 19:03 ` [PATCH net v2 10/10] net: fill in MODULE_DESCRIPTION()s for rvu_mbox Breno Leitao
@ 2024-01-24 23:20 ` patchwork-bot+netdevbpf
10 siblings, 0 replies; 14+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-24 23:20 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, dsahern, weiwan, netdev,
linux-kernel
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 23 Jan 2024 11:03:21 -0800 you wrote:
> There are hundreds of network modules that misses MODULE_DESCRIPTION(),
> causing a warnning when compiling with W=1. Example:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o
>
> [...]
Here is the summary with links:
- [net,v2,01/10] net: fill in MODULE_DESCRIPTION()s for 8390
https://git.kernel.org/netdev/net/c/f5e414167be7
- [net,v2,02/10] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac
https://git.kernel.org/netdev/net/c/39535d7ff6c1
- [net,v2,03/10] net: fill in MODULE_DESCRIPTION()s for liquidio
https://git.kernel.org/netdev/net/c/bb567fbbbbb4
- [net,v2,04/10] net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth
https://git.kernel.org/netdev/net/c/53c83e2d3648
- [net,v2,05/10] net: fill in MODULE_DESCRIPTION()s for nps_enet
https://git.kernel.org/netdev/net/c/27881ca8c8e1
- [net,v2,06/10] net: fill in MODULE_DESCRIPTION()s for enetc
https://git.kernel.org/netdev/net/c/07c42d237567
- [net,v2,07/10] net: fill in MODULE_DESCRIPTION()s for fec
https://git.kernel.org/netdev/net/c/2e8757648855
- [net,v2,08/10] net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio
https://git.kernel.org/netdev/net/c/8183c470c176
- [net,v2,09/10] net: fill in MODULE_DESCRIPTION()s for litex
https://git.kernel.org/netdev/net/c/07d1e0ce8743
- [net,v2,10/10] net: fill in MODULE_DESCRIPTION()s for rvu_mbox
https://git.kernel.org/netdev/net/c/bdc6734115d7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2024-01-24 23:20 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-23 19:03 [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 01/10] net: fill in MODULE_DESCRIPTION()s for 8390 Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 02/10] net: fill in MODULE_DESCRIPTION()s for Broadcom bgmac Breno Leitao
2024-01-23 19:27 ` Florian Fainelli
2024-01-23 19:03 ` [PATCH net v2 03/10] net: fill in MODULE_DESCRIPTION()s for liquidio Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 04/10] net: fill in MODULE_DESCRIPTION()s for ep93xxx_eth Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 05/10] net: fill in MODULE_DESCRIPTION()s for nps_enet Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 06/10] net: fill in MODULE_DESCRIPTION()s for enetc Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 07/10] net: fill in MODULE_DESCRIPTION()s for fec Breno Leitao
2024-01-24 1:13 ` Wei Fang
2024-01-23 19:03 ` [PATCH net v2 08/10] net: fill in MODULE_DESCRIPTION()s for fsl_pq_mdio Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 09/10] net: fill in MODULE_DESCRIPTION()s for litex Breno Leitao
2024-01-23 19:03 ` [PATCH net v2 10/10] net: fill in MODULE_DESCRIPTION()s for rvu_mbox Breno Leitao
2024-01-24 23:20 ` [PATCH net v2 00/10] Fix MODULE_DESCRIPTION() for net (p2) patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).