netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Gal Pressman <gal@nvidia.com>
Subject: [net 04/14] net/mlx5e: Fix inconsistent hairpin RQT sizes
Date: Wed, 24 Jan 2024 00:18:45 -0800	[thread overview]
Message-ID: <20240124081855.115410-5-saeed@kernel.org> (raw)
In-Reply-To: <20240124081855.115410-1-saeed@kernel.org>

From: Tariq Toukan <tariqt@nvidia.com>

The processing of traffic in hairpin queues occurs in HW/FW and does not
involve the cpus, hence the upper bound on max num channels does not
apply to them.  Using this bound for the hairpin RQT max_table_size is
wrong.  It could be too small, and cause the error below [1].  As the
RQT size provided on init does not get modified later, use the same
value for both actual and max table sizes.

[1]
mlx5_core 0000:08:00.1: mlx5_cmd_out_err:805:(pid 1200): CREATE_RQT(0x916) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x538faf), err(-22)

Fixes: 74a8dadac17e ("net/mlx5e: Preparations for supporting larger number of channels")
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 30932c9c9a8f..047b465fc6a5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -761,7 +761,7 @@ static int mlx5e_hairpin_create_indirect_rqt(struct mlx5e_hairpin *hp)
 
 	err = mlx5e_rss_params_indir_init(&indir, mdev,
 					  mlx5e_rqt_size(mdev, hp->num_channels),
-					  mlx5e_rqt_size(mdev, priv->max_nch));
+					  mlx5e_rqt_size(mdev, hp->num_channels));
 	if (err)
 		return err;
 
-- 
2.43.0


  parent reply	other threads:[~2024-01-24  8:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  8:18 [pull request][net 00/14] mlx5 fixes 2024-01-24 Saeed Mahameed
2024-01-24  8:18 ` [net 01/14] net/mlx5e: Use the correct lag ports number when creating TISes Saeed Mahameed
2024-01-25 11:00   ` patchwork-bot+netdevbpf
2024-01-24  8:18 ` [net 02/14] net/mlx5: Fix query of sd_group field Saeed Mahameed
2024-01-24  8:18 ` [net 03/14] net/mlx5e: Fix operation precedence bug in port timestamping napi_poll context Saeed Mahameed
2024-01-24  8:18 ` Saeed Mahameed [this message]
2024-01-24  8:18 ` [net 05/14] net/mlx5e: Fix peer flow lists handling Saeed Mahameed
2024-01-24  8:18 ` [net 06/14] net/mlx5: Fix a WARN upon a callback command failure Saeed Mahameed
2024-01-24  8:18 ` [net 07/14] net/mlx5: Bridge, fix multicast packets sent to uplink Saeed Mahameed
2024-01-24  8:18 ` [net 08/14] net/mlx5: DR, Use the right GVMI number for drop action Saeed Mahameed
2024-01-24  8:18 ` [net 09/14] net/mlx5: DR, Can't go to uplink vport on RX rule Saeed Mahameed
2024-01-24  8:18 ` [net 10/14] net/mlx5: Use mlx5 device constant for selecting CQ period mode for ASO Saeed Mahameed
2024-01-24  8:18 ` [net 11/14] net/mlx5e: Allow software parsing when IPsec crypto is enabled Saeed Mahameed
2024-01-24  8:18 ` [net 12/14] net/mlx5e: Ignore IPsec replay window values on sender side Saeed Mahameed
2024-01-24  8:18 ` [net 13/14] net/mlx5e: fix a double-free in arfs_create_groups Saeed Mahameed
2024-01-24  8:18 ` [net 14/14] net/mlx5e: fix a potential double-free in fs_any_create_groups Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124081855.115410-5-saeed@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).