From: Simon Horman <horms@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, magnus.karlsson@intel.com
Subject: Re: [PATCH iwl-next 2/2] ice: make ice_vsi_cfg_txq() static
Date: Wed, 24 Jan 2024 10:09:42 +0000 [thread overview]
Message-ID: <20240124100942.GT254773@kernel.org> (raw)
In-Reply-To: <20240123115846.559559-3-maciej.fijalkowski@intel.com>
On Tue, Jan 23, 2024 at 12:58:46PM +0100, Maciej Fijalkowski wrote:
> Currently, XSK control path in ice driver calls directly
> ice_vsi_cfg_txq() whereas we have ice_vsi_cfg_single_txq() for that
> purpose. Use the latter from XSK side and make ice_vsi_cfg_txq() static.
>
> ice_vsi_cfg_txq() resides in ice_base.c and is rather big, so to reduce
> the code churn let us move the callers of it from ice_lib.c to
> ice_base.c.
>
> This change puts ice_qp_ena() on nice diet due to the checks and
> operations that ice_vsi_cfg_single_{r,t}xq() do internally.
>
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-182 (-182)
> Function old new delta
> ice_xsk_pool_setup 2165 1983 -182
> Total: Before=472597, After=472415, chg -0.04%
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-01-24 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 11:58 [PATCH iwl-next 0/2] ice: use ice_vsi_cfg_single_{r,t}xq in XSK Maciej Fijalkowski
2024-01-23 11:58 ` [PATCH iwl-next 1/2] ice: make ice_vsi_cfg_rxq() static Maciej Fijalkowski
2024-01-24 10:09 ` Simon Horman
2024-01-31 3:19 ` [Intel-wired-lan] " Rout, ChandanX
2024-01-23 11:58 ` [PATCH iwl-next 2/2] ice: make ice_vsi_cfg_txq() static Maciej Fijalkowski
2024-01-24 10:09 ` Simon Horman [this message]
2024-01-31 3:16 ` [Intel-wired-lan] " Rout, ChandanX
2024-01-24 7:59 ` [PATCH iwl-next 0/2] ice: use ice_vsi_cfg_single_{r,t}xq in XSK Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124100942.GT254773@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).